Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #3418: Separate DeveloperOptionsActivityTest into activity and fragment test files #3516

Merged
merged 7 commits into from
Jul 30, 2021
Merged

Fix #3418: Separate DeveloperOptionsActivityTest into activity and fragment test files #3516

merged 7 commits into from
Jul 30, 2021

Conversation

yashraj-01
Copy link
Contributor

Explanation

Fixes #3418. Separated DeveloperOptionsActivityTest into activity and fragment test files. This PR is based on the comments on the PR #3471.

Screenshots

  • Expresso test results for DeveloperOptionsActivityTest
    Screenshot from 2021-07-22 20-24-29

  • Expresso test results for DeveloperOptionsFrgmentTest
    Screenshot from 2021-07-22 20-22-37

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@BenHenning
Copy link
Sponsor Member

Deferring to @Sarthak2601 to perform a first pass based on #3471.

@BenHenning BenHenning removed their assignment Jul 23, 2021
Sarthak2601
Sarthak2601 suggested changes Jul 26, 2021
View reviewed changes
Copy link
Contributor

@Sarthak2601 Sarthak2601 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, left some additional thoughts.

app/src/sharedTest/java/org/oppia/android/app/devoptions/DeveloperOptionsFragmentTest.kt Show resolved Hide resolved
app/src/sharedTest/java/org/oppia/android/app/devoptions/DeveloperOptionsFragmentTest.kt Outdated Show resolved Hide resolved
@oppiabot
Copy link

oppiabot bot commented Jul 26, 2021

Unassigning @Sarthak2601 since the review is done.

@oppiabot
Copy link

oppiabot bot commented Jul 26, 2021

Hi @yashraj-01, it looks like some changes were requested on this pull request by @Sarthak2601. PTAL. Thanks!

rt4914
rt4914 approved these changes Jul 26, 2021
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Add tests as per @Sarthak2601 comments.

@rt4914 rt4914 removed their assignment Jul 26, 2021
@oppiabot
Copy link

oppiabot bot commented Jul 26, 2021

Assigning @BenHenning for code owner reviews. Thanks!

@yashraj-01 yashraj-01 assigned Sarthak2601 and unassigned yashraj-01 Jul 27, 2021
Sarthak2601
Sarthak2601 reviewed Jul 27, 2021
View reviewed changes
Copy link
Contributor

@Sarthak2601 Sarthak2601 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left thoughts on existing review comments.

app/src/sharedTest/java/org/oppia/android/app/devoptions/DeveloperOptionsFragmentTest.kt Outdated Show resolved Hide resolved
@BenHenning
Copy link
Sponsor Member

Will need to look at this tomorrow--I've got to load balance my current PR load.

Sarthak2601
Sarthak2601 approved these changes Jul 29, 2021
View reviewed changes
Copy link
Contributor

@Sarthak2601 Sarthak2601 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Sarthak2601 Sarthak2601 removed their assignment Jul 29, 2021
BenHenning
BenHenning approved these changes Jul 30, 2021
View reviewed changes
Copy link
Sponsor Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yashraj-01! LGTM.

scripts/assets/accessibility_label_exemptions.textproto
Comment on lines +1 to +2
exempted_activity: "app/src/main/java/org/oppia/android/app/devoptions/markchapterscompleted/testing/MarkChaptersCompletedTestActivity"
exempted_activity: "app/src/main/java/org/oppia/android/app/devoptions/markstoriescompleted/testing/MarkStoriesCompletedTestActivity"
Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't these be added in earlier PRs, or were they missed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They were missed actually.

@BenHenning BenHenning enabled auto-merge (squash) July 30, 2021 06:39
@BenHenning BenHenning assigned yashraj-01 and unassigned BenHenning Jul 30, 2021
@oppiabot oppiabot bot added the PR: LGTM label Jul 30, 2021
@BenHenning BenHenning merged commit dd391ea into develop Jul 30, 2021
@BenHenning BenHenning deleted the separate-developer-options-test branch July 30, 2021 06:54
@yashraj-01 yashraj-01 mentioned this pull request Jul 30, 2021
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rt4914 rt4914 rt4914 approved these changes

@BenHenning BenHenning BenHenning approved these changes

@Sarthak2601 Sarthak2601 Sarthak2601 approved these changes

Assignees

@yashraj-01 yashraj-01

Labels
PR: LGTM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Separate DeveloperOptionsActivityTest into activity and fragment test files
4 participants
@yashraj-01 @BenHenning @rt4914 @Sarthak2601