Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3472: Deleted the landing activity xml file #3517

Conversation

yash10019coder
Copy link
Contributor

@yash10019coder yash10019coder commented Jul 23, 2021

Explanation

Fix #3472
In this, I have deleted the landscape XML file of this as it had two files and I also compared the two files before but they were same so there was nothing to add in dimens.xml file
Now @rt4914 PTAL @prayutsu

These are the screenshots of the activity

New Screenshots Old Screenshots
Screenshot from 2021-07-23 22-13-34 Screenshot from 2021-07-24 12-53-27
Screenshot from 2021-07-23 22-14-10 Screenshot from 2021-07-24 12-52-14
Screenshot from 2021-07-23 23-13-39 Screenshot from 2021-07-24 12-54-24
Screenshot from 2021-07-23 23-14-04 Screenshot from 2021-07-24 12-54-51

In the last screenshot there is a scroll view so the whole page is scrollable

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@yash10019coder yash10019coder changed the title Deleted the land ing activity xml file Deleted the landing activity xml file Jul 23, 2021
@yash10019coder yash10019coder changed the title Deleted the landing activity xml file Fixes #3472 : Deleted the landing activity xml file Jul 23, 2021
@yash10019coder yash10019coder changed the title Fixes #3472 : Deleted the landing activity xml file Fixes #3472: Deleted the landing activity xml file Jul 23, 2021
@prayutsu
Copy link
Contributor

@yash10019coder From the PR description, it is not clear if the screenshots attached were taken before the changes or they have been taken after the changes, to compare we'll need both screenshots.
You can make a table of before and after screenshots with the help of Markdown easily.

Before After
Screenshot Before the changes Screenshot Before the changes

@yash10019coder
Copy link
Contributor Author

yash10019coder commented Jul 24, 2021

@yash10019coder From the PR description, it is not clear if the screenshots attached were taken before the changes or they have been taken after the changes, to compare we'll need both screenshots.
You can make a table of before and after screenshots with the help of Markdown easily.

Before After
Screenshot Before the changes Screenshot Before the changes

@prayutsu @rt4914 changed the PR description PTAL

@oppiabot oppiabot bot assigned prayutsu and unassigned yash10019coder Jul 24, 2021
@oppiabot
Copy link

oppiabot bot commented Jul 24, 2021

Unassigning @yash10019coder since a re-review was requested. @yash10019coder, please make sure you have addressed all review comments. Thanks!

Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@rt4914 rt4914 merged commit 6082592 into oppia:develop Jul 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge faq_list_activity into single xml layout file
3 participants