Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix part of #140: Changed click listeners on TopicPlay #355

Merged
merged 1 commit into from
Nov 15, 2019

Conversation

rt4914
Copy link
Contributor

@rt4914 rt4914 commented Nov 15, 2019

Explanation

This PR mainly changes the click listeners on the topic play item.

  • Click Item -> Expand/Contract item
  • Click story-name -> Open next activity with detailed chapter-list.

Known Issues:

  • The story-name fails at accessibility test because any clickable item should have atleast 48dp of height.

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@veena14cs
Copy link
Contributor

Its LGTM but it has issue with the touch and we need to fix this.

@veena14cs veena14cs merged commit 6cb5db0 into develop Nov 15, 2019
@veena14cs veena14cs deleted the fix-topic-play-item-click branch November 15, 2019 09:52
@BenHenning
Copy link
Sponsor Member

@rt4914 does this fix #383?

@rt4914
Copy link
Contributor Author

rt4914 commented Nov 18, 2019

@BenHenning Yes, check this comment too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants