Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Audio bar connected items #356

Merged
merged 8 commits into from
Nov 15, 2019
Merged

Fix Audio bar connected items #356

merged 8 commits into from
Nov 15, 2019

Conversation

rt4914
Copy link
Contributor

@rt4914 rt4914 commented Nov 15, 2019

Explanation

This PR fixes following things:

  1. Language name in Language Selection Dialog.
  2. Scroll state-recycler-view when audiobar is visible.
  3. Exploration name and shadow below toolbar.

Mocks
Screenshot 2019-11-15 at 3 22 36 PM

Updated UX.
Screenshot 2019-11-15 at 3 26 25 PM

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

Copy link
Contributor

@veena14cs veena14cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. There was some nit change I have updated it.
One concern was why menu option was introduced in this PR.

@rt4914
Copy link
Contributor Author

rt4914 commented Nov 15, 2019

Made some improvisations even after approval which makes the audiobar scroll much better.

@rt4914 rt4914 merged commit e2b7ab5 into develop Nov 15, 2019
@rt4914 rt4914 deleted the audio-bar-connected-items branch November 15, 2019 15:54
@rt4914 rt4914 mentioned this pull request Jun 24, 2020
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants