Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup Oppiabot stale checks for Oppia Android #3594

Merged
merged 4 commits into from
Aug 13, 2021

Conversation

jameesjohn
Copy link
Contributor

@jameesjohn jameesjohn commented Jul 27, 2021

Explanation

This PR sets up oppiabot stale checks.
It will mark PRs without updates for 6 days as stale, and close them after 4 days.

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@jameesjohn
Copy link
Contributor Author

PTAL @BenHenning

Copy link
Sponsor Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jameesjohn! Just had one comment--PTAL.

.github/stale.yml Outdated Show resolved Hide resolved
@BenHenning BenHenning assigned jameesjohn and unassigned BenHenning Jul 28, 2021
Copy link
Contributor Author

@jameesjohn jameesjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @BenHenning I responded to your comment, PTAL.
Also, how do I fix the failing test? It seems like a code owners check.

.github/stale.yml Outdated Show resolved Hide resolved
@Sparsh1212 Sparsh1212 added the PR don't merge - NEEDS UPDATE Corresponds to PRs that need to be updated with the latest develop changes before they can be merged label Jul 30, 2021
@seanlip seanlip assigned BenHenning and unassigned jameesjohn Aug 4, 2021
@BenHenning
Copy link
Sponsor Member

@jameesjohn apologies for not following up earlier--I tend to only look at assigned PRs since those require my active attention.

To fix the codeowners check you'll need to add the new file to CODEOWNERS (making me the codeowner here should be fine).

@BenHenning BenHenning assigned jameesjohn and unassigned BenHenning Aug 5, 2021
@jameesjohn jameesjohn requested a review from a team as a code owner August 11, 2021 21:59
@jameesjohn
Copy link
Contributor Author

Done.
PTAL @BenHenning. Thanks

@jameesjohn jameesjohn assigned BenHenning and unassigned jameesjohn Aug 11, 2021
Copy link
Sponsor Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jameesjohn! This LGTM--I appreciate you making this config change for us.

@BenHenning BenHenning merged commit 68217e6 into oppia:develop Aug 13, 2021
@BenHenning BenHenning removed the PR don't merge - NEEDS UPDATE Corresponds to PRs that need to be updated with the latest develop changes before they can be merged label Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants