Fix #431: Fixed Profile Page Cut-Off For Small Display

[Pranav-Bobde]

Explanation

Fixes #431: Added Proper dimensions for profile_chooser_fragment.xml and profile_chooser_profile_view.xml

• The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
• The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
• The PR follows the style guide.
• The PR does not contain any unnecessary auto-generated code from Android Studio.
• The PR is made from a branch that's not called "develop".
• The PR is made from a branch that is up-to-date with "develop".
• The PR's branch is based on "develop" and not on any other branch.
• The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

Screenshots:
Link For PPT : https://docs.google.com/presentation/d/1xDsWh7fNsDh4Ux8AJNPUIPyaSqSHbBan/edit#slide=id.p3
BEFORE                    AFTER
PORTRAIT - 3.4 WQVGA (ldpi)
            
LANDSCAPE - 3.4 WQVGA (ldpi)
            
PORTRAIT - 5.4 FWVGA (mdpi)
            
LANDSCAPE - 5.4 FWVGA (mdpi)
            
PORTRAIT - Nexus S (hdpi)
            
LANDSCAPE - Nexus S (hdpi)
            
PORTRAIT - Pixel (420dpi)
            
LANDSCAPE - Pixel (420dpi)
            
PORTRAIT - 10.1 WXGA (Tablet) (mdpi)
            
LANDSCAPE - 10.1 WXGA (Tablet) (mdpi)
            

[rt4914]

Thanks for the PR @Pranav-Bobde .
Three suggestions:

1. There should be End-of-file on each file. Basically one blank line after all the code in the file.
2. All dimens should be in multiple of 4.
3. Add screenshots of this screen for mobile portrait, mobile landscape, tablet portrait and tablet landscape.

[Pranav-Bobde]

working on it

[rt4914]

working on it

@Pranav-Bobde Please comment on the issue not on this pull-request so that I can assign it to you. #431

[Pranav-Bobde]

working on it

@Pranav-Bobde Please comment on the issue not on this pull-request so that I can assign it to you. #431
@rt4914 Sorry about that.
Added the Screenshots, PTAL.

[oppiabot]

Unassigning @Pranav-Bobde since a re-review was requested. @Pranav-Bobde, please make sure you have addressed all review comments. Thanks!

[rt4914]

Also, @Pranav-Bobde Please do not resolve comments on your own. Just reply to the comments and the person who has started the comment thread will verify it based upon your answer and then resolve it.

[rt4914]

Also in first screenshot the space above and below the line looks inconsistent can you please fix that too.

[Pranav-Bobde]

Also in first screenshot the space above and below the line looks inconsistent can you please fix that too.

@rt4914 Yeah, it's the same gap that i asked in my doc. I did try to look in the xml files you mentioned too but i couldn't find it. So, if you could help find it will try to alter it accordingly ASAP. Thanks.

[rt4914]

@Pranav-Bobde Checkout profile_chooser_add_view.xml in this you might need to create a dimens value of profile_chooser_add_view_margin_top_profile_not_added on smaller devices.

Also, can you add screenshots of before/after images of multiple profile for all these screens so that we can be sure that when there are multiple profiles the UI is not affected because of this PR.

[Pranav-Bobde]

@rt4914
Have updated the PPT with new Screenshots. Please let me know if they all seem right.

Thanks.

[Pranav-Bobde]

@rt4914
2 checks seems to be failing. Can you tell me how to redo the check? since i guess in the past too just renunning the checks used to resolve the problem.

[rt4914]

@Pranav-Bobde I think you cannot re-run the checks right now. I have re-run the checks. Also, you can do two things:

1. Update with develop
2. Also can you update screenshots either here or in ppt so that we can see if screenshots are looking good.

[Pranav-Bobde]

@Pranav-Bobde I think you cannot re-run the checks right now. I have re-run the checks. Also, you can do two things:

1. Update with develop
2. Also can you update screenshots either here or in ppt so that we can see if screenshots are looking good.

@rt4914 Actually i had already updated the screenshots in the ppt as per your comments. And replied there to review them. So, if they all look good i will update them here too.

[Pranav-Bobde]

@rt4914 Have updated the screenshots and added the link to PPT too. PTAL.

[oppiabot]

Unassigning @Pranav-Bobde since a re-review was requested. @Pranav-Bobde, please make sure you have addressed all review comments. Thanks!

[rt4914]

@Pranav-Bobde Overall looks really good. Just some final nit changes and it will be good to merge.

[oppiabot]

Unassigning @rt4914 since the review is done.

[oppiabot]

Hi @Pranav-Bobde, it looks like some changes were requested on this pull request by @rt4914. PTAL. Thanks!

[rt4914]

LGTM, thanks.