Fix #3583: Merge topic_practice_footer_view into single layout file.

[rishidyno]

Explanation

Fix #3583

Checklist

• The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
• The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
• The PR follows the style guide.
• The PR does not contain any unnecessary auto-generated code from Android Studio.
• The PR is made from a branch that's not called "develop".
• The PR is made from a branch that is up-to-date with "develop".
• The PR's branch is based on "develop" and not on any other branch.
• The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

OLD Screenshots	NEW Screenshots

[rt4914]

@rishidyno There are 4 files which needs to be merged into 1.

Also as mentioned in issue please add before/after screenshots of this UI in app in mobile portrait/landscape and tablet portrait/landscape mode.

[rishidyno]

@rishidyno There are 4 files which needs to be merged into 1.

Also as mentioned in issue please add before/after screenshots of this UI in app in mobile portrait/landscape and tablet portrait/landscape mode.

@rt4914 I have added Screenshots also I wanted to mention that I tried merging it into one XML file but I ran into some issues.

I added these two in mobile portrait/landscape dimens.xml beacause these two are identicle.

<dimen name="topic_practice_footer_view_margin_top">36dp</dimen>
<dimen name="topic_practice_footer_view_margin_bottom">108dp</dimen>

Also i added these two in tablet portrait/landscape dimens.xml beacause these two are identicle.

<dimen name="topic_practice_footer_view_margin_top">24dp</dimen>
<dimen name="topic_practice_footer_view_margin_bottom">0dp</dimen>

But when I tried to run the app in that activity it crashed in tablet portrait/landscape so I kept the tablet portrait and landscape file.

I could not get a complete understanding of why they crashed. But I think it might be due to other layout elements surrounding them.

I could only delete the landscape file.

Please guide me on what to do now.

[rt4914]

@rishidyno There are 4 files which needs to be merged into 1.
Also as mentioned in issue please add before/after screenshots of this UI in app in mobile portrait/landscape and tablet portrait/landscape mode.

@rt4914 I have added Screenshots also I wanted to mention that I tried merging it into one XML file but I ran into some issues.

I added these two in mobile portrait/landscape dimens.xml beacause these two are identicle.

<dimen name="topic_practice_footer_view_margin_top">36dp</dimen>
<dimen name="topic_practice_footer_view_margin_bottom">108dp</dimen>

Also i added these two in tablet portrait/landscape dimens.xml beacause these two are identicle.

<dimen name="topic_practice_footer_view_margin_top">24dp</dimen>
<dimen name="topic_practice_footer_view_margin_bottom">0dp</dimen>

But when I tried to run the app in that activity it crashed in tablet portrait/landscape so I kept the tablet portrait and landscape file.

I could not get a complete understanding of why they crashed. But I think it might be due to other layout elements surrounding them.

I could only delete the landscape file.

Please guide me on what to do now.

@rishidyno After you have done the changes for by removing the tablet xml file also, rebuild the entire project, uninstall the previous app from tablet device and then install the app. It should work properly after that.

[rishidyno]

@rishidyno There are 4 files which needs to be merged into 1.
Also as mentioned in issue please add before/after screenshots of this UI in app in mobile portrait/landscape and tablet portrait/landscape mode.

@rt4914 I have added Screenshots also I wanted to mention that I tried merging it into one XML file but I ran into some issues.
I added these two in mobile portrait/landscape dimens.xml beacause these two are identicle.
<dimen name="topic_practice_footer_view_margin_top">36dp</dimen>
<dimen name="topic_practice_footer_view_margin_bottom">108dp</dimen>
Also i added these two in tablet portrait/landscape dimens.xml beacause these two are identicle.
<dimen name="topic_practice_footer_view_margin_top">24dp</dimen>
<dimen name="topic_practice_footer_view_margin_bottom">0dp</dimen>
But when I tried to run the app in that activity it crashed in tablet portrait/landscape so I kept the tablet portrait and landscape file.
I could not get a complete understanding of why they crashed. But I think it might be due to other layout elements surrounding them.
I could only delete the landscape file.
Please guide me on what to do now.

@rishidyno After you have done the changes for by removing the tablet xml file also, rebuild the entire project, uninstall the previous app from tablet device and then install the app. It should work properly after that.

Thanks a lot @rt4914 I followed what you said and I was able to merge it into a single layout file.
Now it only needs to be reviewed by you.

[prayutsu]

Left two comments, PTAL @rishidyno.
Also, note that if you want any reviewers to add their review, you should assign them the PR. Reviewers only add their reviews to the PRs assigned to them.

[rishidyno]

Ptal @rt4914

Left two comments, PTAL @rishidyno.
Also, note that if you want any reviewers to add their review, you should assign them the PR. Reviewers only add their reviews to the PRs assigned to them.

Got it 🙂

[oppiabot]

Unassigning @rishidyno since a re-review was requested. @rishidyno, please make sure you have addressed all review comments. Thanks!

[prayutsu]

LGTM, Thanks @rishidyno

[rishidyno]

LGTM, Thanks @rishidyno

Thanks @prayutsu

[rt4914]

@rishidyno Code is good. Just nit changes suggested.

[rt4914]

LGTM, thanks.