Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3647: add @Binds annotation to be exempted and automatically exempt test files #3648

Merged
merged 2 commits into from
Aug 6, 2021

Conversation

Sparsh1212
Copy link
Contributor

@Sparsh1212 Sparsh1212 commented Aug 5, 2021

Explanation

Fixes: #3647: Adds "@BINDS" annotation entry to be exempted and automatically exempts all the test files.

Binds Annotation test and Test file missing KDoc test failing before this fix:
image
image

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@Sparsh1212 Sparsh1212 changed the title Fix #3647: add annotation, automatically exempt test files Fix #3647: add @Binds annotation to be exempted and automatically exempt test files Aug 5, 2021
@Sparsh1212
Copy link
Contributor Author

Sparsh1212 commented Aug 5, 2021

@BenHenning PTAL:

  • Added "@BINDS" annotation entry to be exempted
  • Added test for this newly added annotation entry
  • Automatically exempts all Test files for KDoc check
  • Added test for this new automatic exemption of Test files

Copy link
Sponsor Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Sparsh1212! This was a really quick turnaround, and the PR generally looks great. Just have one request to firm up the bug fix aspect of the PR, but it otherwise LGTM.

@BenHenning BenHenning assigned Sparsh1212 and unassigned BenHenning Aug 6, 2021
@Sparsh1212 Sparsh1212 assigned BenHenning and unassigned Sparsh1212 Aug 6, 2021
@Sparsh1212
Copy link
Contributor Author

Updated with latest develop

Copy link
Sponsor Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Sparsh1212. LGTM!

@BenHenning BenHenning merged commit 92fecac into develop Aug 6, 2021
@BenHenning BenHenning deleted the add-binds-remove-test-files-for-check branch August 6, 2021 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add missed annotation for KDoc check and automatically exempt all test files
2 participants