Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #3656: [RTL] High-fi Add support for RTL in Story Activity #3667

Merged
merged 58 commits into from
Aug 18, 2021
Merged

Fix #3656: [RTL] High-fi Add support for RTL in Story Activity #3667

merged 58 commits into from
Aug 18, 2021

Conversation

veena14cs
Copy link
Contributor

@veena14cs veena14cs commented Aug 10, 2021 •
edited

Explanation

This PR fixes #3656 . This PR focuses on textalignment in storyView.

Screenshots LTR and RTL

Mobile
Screenshot_1629114810....Screenshot_1629114759

Screenshot_1629114799.....Screenshot_1629114768

Tablet
Screenshot_1629115032......Screenshot_1629115311
Screenshot_1629115325.....Screenshot_1629115023

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@veena14cs
Update selection_interaction_item.xml
76c542f
@veena14cs
Merge remote-tracking branch 'upstream/develop' into develop
03dbae2
@veena14cs
Update selection_interaction_item.xml
1eaa794
@veena14cs
Merge remote-tracking branch 'upstream/develop' into develop
c122fa9
@veena14cs
Update return_to_topic_button_item.xml
fa01718
@veena14cs
Update return_to_topic_button_item.xml
1ddff1b
@veena14cs
Merge remote-tracking branch 'upstream/develop' into develop
75f3191
@veena14cs
Merge remote-tracking branch 'upstream/develop' into develop
0153870
@veena14cs
Merge remote-tracking branch 'upstream/develop' into develop
b655173
@veena14cs
Merge remote-tracking branch 'upstream/develop' into develop
251b720
@veena14cs
Merge remote-tracking branch 'upstream/develop' into develop
21402ab
@veena14cs
Merge remote-tracking branch 'upstream/develop' into develop
77ed59c
@veena14cs
Merge remote-tracking branch 'upstream/develop' into develop
dd9379c
@veena14cs
Merge remote-tracking branch 'upstream/develop' into develop
eceec2f
@veena14cs
Merge remote-tracking branch 'upstream/develop' into develop
b136ffc
@veena14cs
Merge remote-tracking branch 'upstream/develop' into develop
d01b5e6
@veena14cs
Merge remote-tracking branch 'upstream/develop' into develop
1494b90
@veena14cs
Merge remote-tracking branch 'upstream/develop' into develop
231a322
@veena14cs
Merge remote-tracking branch 'upstream/develop' into develop
2d744e1
@veena14cs
Merge remote-tracking branch 'upstream/develop' into develop
77d9961
@veena14cs
Merge remote-tracking branch 'upstream/develop' into develop
26bd197
@veena14cs
Merge remote-tracking branch 'upstream/develop' into develop
754b2b1
@veena14cs
Merge remote-tracking branch 'upstream/develop' into develop
839e45a
@veena14cs
Merge remote-tracking branch 'upstream/develop' into develop
005553c
@veena14cs
Merge remote-tracking branch 'upstream/develop' into develop
8fa1abd
@veena14cs
Merge remote-tracking branch 'upstream/develop' into develop
3b6cbda
@veena14cs
Merge remote-tracking branch 'upstream/develop' into develop
d089c26
@veena14cs
Merge remote-tracking branch 'upstream/develop' into develop
4e49e45
@veena14cs
Merge remote-tracking branch 'upstream/develop' into develop
ed7044b
@veena14cs
Merge remote-tracking branch 'upstream/develop' into develop
17a0935
@oppiabot
Copy link

oppiabot bot commented Aug 16, 2021

Hi @veena14cs, it looks like some changes were requested on this pull request by @rt4914. PTAL. Thanks!

@veena14cs veena14cs assigned rt4914 and unassigned veena14cs Aug 16, 2021
@veena14cs veena14cs requested a review from rt4914 August 16, 2021 20:01
BenHenning
BenHenning requested changes Aug 16, 2021
View reviewed changes
Copy link
Sponsor Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one follow-up comment.

@veena14cs can you please also add tests for these changes to make sure they're well tested?

app/src/main/res/layout-land/story_chapter_view.xml
android:layout_height="wrap_content"
android:layout_marginStart="8dp"
android:layout_marginTop="8dp"
android:layout_marginEnd="8dp"
android:layout_marginBottom="4dp"
android:fontFamily="sans-serif"
android:textAlignment="viewStart"
Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine, though I'm unsure when we should be using textStart vs. viewStart. @veena14cs does textStart have the same behavior? Per documentation it may be better to always default to textStart since it's more likely to look correct (since it provides alignment based on the paragraph rather than the view), while also accounting for RTL scenarios.

@BenHenning BenHenning assigned veena14cs and unassigned BenHenning Aug 16, 2021
@veena14cs veena14cs assigned BenHenning and unassigned veena14cs Aug 17, 2021
@veena14cs
Copy link
Contributor Author

Left one follow-up comment.

@veena14cs can you please also add tests for these changes to make sure they're well tested?

Followed up with your comment and added tests for the same.

rt4914
rt4914 approved these changes Aug 17, 2021
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@rt4914 rt4914 removed their assignment Aug 17, 2021
@veena14cs
Copy link
Contributor Author

LGTM, thanks.

Thanks @rt4914

BenHenning
BenHenning approved these changes Aug 18, 2021
View reviewed changes
Copy link
Sponsor Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @veena14cs. This LGTM.

@oppiabot
Copy link

oppiabot bot commented Aug 18, 2021

Unassigning @BenHenning since they have already approved the PR.

@oppiabot oppiabot bot added the PR: LGTM label Aug 18, 2021
@veena14cs veena14cs merged commit af5ce27 into oppia:develop Aug 18, 2021
@veena14cs veena14cs deleted the fix-story-view branch August 18, 2021 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rt4914 rt4914 rt4914 approved these changes

@BenHenning BenHenning BenHenning approved these changes

Assignees
No one assigned
Labels
PR: LGTM Type: Task A single task of work corresponding to a greater milestone. Generally corresponds to a single PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RTL] High-fi Add support for RTL in Story Activity
4 participants
@veena14cs @seanlip @rt4914 @BenHenning