-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #2266: [RTL] High-fi Admin and User PinVerification Screen #3684
Conversation
@rt4914 I have addressed and updated the changes
Updated screenshots in PR description. PTAL Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @veena14cs. This LGTM; deferring to Rajat for final approval.
@rt4914 please re-add me if anything changes from the build or testing side.
app/src/sharedTest/java/org/oppia/android/app/profile/PinPasswordActivityTest.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
Explanation
This PR fixes #2266 . This PR implements new design for Admin and User Pin Verification
Older implementation of Pin Verification UI was using PinView library which was not supporting RTL. To fix this we removed this library and created new UI as per the new mocks.
Old Screenshot LTR and RTL
........
........
New Screenshot LTR and RTL
...
.....
Tablet
.....
.....
Mock links
Mobile Portrait : https://xd.adobe.com/view/3dca36c2-5115-419c-b25e-0f10526b077c-6899/screen/4d274b3e-c27b-438a-8c74-c0ff16134080/
Mobile Landscape : https://xd.adobe.com/view/ee9e607b-dbd6-4372-48dc-b687d32af3da-98af/screen/327723da-a1e8-40e4-aace-9c30d663b20b/
Tablet Portrait : https://xd.adobe.com/view/d405de00-a871-4f0f-73a0-f8acef30349b-a234/screen/8de829a5-fc1c-4083-b510-44c1387ed9c2/
Tablet Landscape : https://xd.adobe.com/view/d405de00-a871-4f0f-73a0-f8acef30349b-a234/screen/0648610b-7d70-403c-a42e-a206be75e85f/
Checklist