Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localisation updates from https://translatewiki.net. #3687

Merged
merged 2 commits into from
Sep 15, 2021

Conversation

translatewiki
Copy link
Member

Translation updates

@rt4914 rt4914 self-assigned this Aug 17, 2021
@rt4914
Copy link
Contributor

rt4914 commented Aug 17, 2021

@BenHenning How should I review this PR, any tips?

@BenHenning BenHenning self-assigned this Aug 17, 2021
@BenHenning
Copy link
Sponsor Member

@rt4914 I'll take a first pass. We might want to change codeowners here actually.

@BenHenning
Copy link
Sponsor Member

FYI I'll take a pass on this tomorrow or later in the week.

@BenHenning BenHenning self-requested a review August 18, 2021 07:27
@rt4914 rt4914 removed their assignment Aug 18, 2021
@translatewiki translatewiki force-pushed the translatewiki-prs branch 2 times, most recently from 92f0c30 to 7baee3c Compare August 23, 2021 11:10
@translatewiki translatewiki force-pushed the translatewiki-prs branch 2 times, most recently from 9d19106 to defc834 Compare August 30, 2021 11:14
@BenHenning
Copy link
Sponsor Member

NB: some of the strings were mistranslated and will need to be fixed now that #3754 has landed.

@BenHenning
Copy link
Sponsor Member

Filed #3786 for failing CI.

Copy link
Sponsor Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some issues with certain strings, but with the FAQ ones in most issues are aesthetic. We'll be doing closer QA tests later this week & can catalog specific issues that we want to fix. Otherwise, I suspect these strings are in a good place for our upcoming launch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants