Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3673: Concept card bottom padding #3688

Merged
merged 1 commit into from
Aug 18, 2021
Merged

Conversation

rt4914
Copy link
Contributor

@rt4914 rt4914 commented Aug 16, 2021

Explanation

Fixes #3673: Concept card bottom padding

Earlier the text was getting cropped as shown in issue image. This has been fixed now

device-2021-08-16-211825

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

Copy link
Contributor

@prayutsu prayutsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@oppiabot oppiabot bot unassigned prayutsu Aug 16, 2021
@oppiabot
Copy link

oppiabot bot commented Aug 16, 2021

Unassigning @prayutsu since they have already approved the PR.

@oppiabot oppiabot bot added the PR: LGTM label Aug 16, 2021
@rt4914 rt4914 merged commit b427643 into develop Aug 18, 2021
@rt4914 rt4914 deleted the fix-bottom-padding branch August 18, 2021 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bottom text cutting for ConceptCard
2 participants