-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #3465 Merge completed activity into single file #3689
Fixes #3465 Merge completed activity into single file #3689
Conversation
@vrajdesai78 I think you will need to update your branch by merging with latest develop. |
@rt4914 Please review my pull request |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vrajdesai78 PTAL.
Thanks.
@vrajdesai78 Please do not resolve comments. Actually you should reply to the comments mentioning whether they are done or not and based on your reply I will review it and then if needed I will resolve the comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
Ok next time I won't resolve comments. Thank you for merging my pull request. |
Explanation
I have merged completed_story_item and completed_story_list_fragment into single files by giving it's dimension in dimens.xml file.
Checklist