Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3108: Applied dimens value navigation_drawer_width to layout_width #3702

Merged
merged 3 commits into from
Aug 30, 2021

Conversation

UttaranDas
Copy link
Contributor

@UttaranDas UttaranDas commented Aug 18, 2021

Explanation

Fix #3108

Changed layout_width values to navigation_drawer_width value from the dimens.xml. Earlier there was UI inconsistency in the Developer Options . The layout_width was set to match_parent, which has been now changed through this PR.

Before and after screenshots:

Before After
image image
image image
image image
image image
image image

@rt4914 PTAL

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@github-actions
Copy link

Hi! @UttaranDas Welcome to Oppia! Could you please follow the instructions here and sign the CLA Sheet to get started? You'll need to do this before we can accept your PR. Thanks!

@rt4914 rt4914 self-assigned this Aug 23, 2021
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.
@UttaranDas Can you update the PR with latest develop.
It might work in CI check passes.
If it fails after that too, can you reply to that same email thread with Sean so that he can look into the issue.

@rt4914 rt4914 assigned UttaranDas and unassigned rt4914 Aug 28, 2021
@oppiabot oppiabot bot added the PR: LGTM label Aug 28, 2021
@UttaranDas
Copy link
Contributor Author

@rt4914 I think I messed this PR. I can't create a new PR from this one, so do I need to close this PR?
Or I make another PR from different branch?

@rt4914
Copy link
Contributor

rt4914 commented Aug 30, 2021

Actually the CI checks just passed so merging it now.

@rt4914 rt4914 merged commit 9ed4862 into oppia:develop Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tablet Drawer UI Difference
2 participants