-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude instrumentation tests from generic build patterns #3707
Exclude instrumentation tests from generic build patterns #3707
Conversation
native.android_instrumentation_test( | ||
name = name, | ||
target_device = "@android_test_support//tools/android/emulated_devices/generic_phone:android_23_x86_qemu2", | ||
test_app = ":%sBinary" % name, | ||
tags = ["manual"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I was wondering how to ignore test targets and this was exactly what I was looking for
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't think about there being a tag until today; we probably can revert the ComputeAffectedTests bits but eh.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
Hi @BenHenning, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to merge this PR once the CI checks pass and you're happy with it. Thanks! |
Thanks! Enabling auto-merge. |
Explanation
This change automatically excludes all instrumentation tests from generic patterns like
bazel build //...
since instrumentation tests don't build correctly yet.Reference Bazel documentation for the manual tag: https://docs.bazel.build/versions/main/guide.html#specifying-targets-to-build.
Checklist