Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checks to force RTL layout attributes. #3727

Merged
merged 2 commits into from
Aug 25, 2021
Merged

Conversation

BenHenning
Copy link
Sponsor Member

@BenHenning BenHenning commented Aug 25, 2021

Explanation

Forces RTL attributes by introducing regex check patterns to prohibit all listed on this table, plus some I found when digging into ConstraintLayout specifically.

Reviewer: Please verify that:

  1. This list looks correct to you as valid cases to prohibit
  2. That the list of exemptions are real cases that need to be fixed

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@BenHenning BenHenning marked this pull request as ready for review August 25, 2021 01:56
@BenHenning BenHenning requested a review from rt4914 August 25, 2021 01:56
@BenHenning
Copy link
Sponsor Member Author

@rt4914 PTAL at the new checks being added & let me know if any of these seem wrong to you, plus that the exemptions are cases to fix.

Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really nice to me. Thanks a lot. Let me know once merged so that we can file good-first-issues for the exempted files.

@rt4914 rt4914 assigned BenHenning and unassigned rt4914 Aug 25, 2021
@oppiabot oppiabot bot added the PR: LGTM label Aug 25, 2021
@oppiabot
Copy link

oppiabot bot commented Aug 25, 2021

Hi @BenHenning, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to merge this PR once the CI checks pass and you're happy with it. Thanks!

@BenHenning BenHenning merged commit 17ee91b into develop Aug 25, 2021
@BenHenning BenHenning deleted the add-rtl-layout-checks branch August 25, 2021 05:44
@BenHenning
Copy link
Sponsor Member Author

Done @rt4914 -- now merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants