-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed search icon from faq list and admin controls #3736
Conversation
@@ -21,11 +21,6 @@ class FAQListActivity : InjectableAppCompatActivity(), RouteToFAQSingleListener | |||
faqListActivityPresenter.handleOnCreate() | |||
} | |||
|
|||
override fun onCreateOptionsMenu(menu: Menu?): Boolean { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to check, why is this removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The search_icon was part of menu_faq_list_activity
which is an independent xml file.
This function onCreateOptionsMenu
helps to bind the menu_faq_list_activity
to the Activity/Screen so that we can show the search
icon in header/toolbar.
As we have removed the search_icon
, it means that menu_faq_list_activity
will be empty, therefore we remove it too which means we don't need to bind it to activity anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah ok, thanks! LGTM but let's get Veena's review before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rt4914 LGTM!
Explanation
This PR simply removes the search icon from FAQListActivity and AdministratorControlsActivity. The search icon was not functional and therefore its correct to remove it for now and introduce it when we implement the whole functionality.
Before vs. After
Notice top right corner.
Checklist