Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed search icon from faq list and admin controls #3736

Merged
merged 3 commits into from
Aug 30, 2021

Conversation

rt4914
Copy link
Contributor

@rt4914 rt4914 commented Aug 25, 2021

Explanation

This PR simply removes the search icon from FAQListActivity and AdministratorControlsActivity. The search icon was not functional and therefore its correct to remove it for now and introduce it when we implement the whole functionality.

Before vs. After

Notice top right corner.

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@@ -21,11 +21,6 @@ class FAQListActivity : InjectableAppCompatActivity(), RouteToFAQSingleListener
faqListActivityPresenter.handleOnCreate()
}

override fun onCreateOptionsMenu(menu: Menu?): Boolean {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to check, why is this removed?

Copy link
Contributor Author

@rt4914 rt4914 Aug 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The search_icon was part of menu_faq_list_activity which is an independent xml file.

This function onCreateOptionsMenu helps to bind the menu_faq_list_activity to the Activity/Screen so that we can show the search icon in header/toolbar.

As we have removed the search_icon, it means that menu_faq_list_activity will be empty, therefore we remove it too which means we don't need to bind it to activity anymore.

@seanlip seanlip assigned rt4914 and unassigned seanlip Aug 25, 2021
@rt4914 rt4914 changed the title Removed search icon from faq list Removed search icon from faq list and admin controls Aug 25, 2021
Copy link
Member

@seanlip seanlip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok, thanks! LGTM but let's get Veena's review before merging.

@rt4914 rt4914 removed their assignment Aug 25, 2021
Copy link
Contributor

@veena14cs veena14cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rt4914 LGTM!

@veena14cs veena14cs merged commit 6fa4664 into develop Aug 30, 2021
@veena14cs veena14cs deleted the remove-search-in-faq-list branch August 30, 2021 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants