Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3324: Created BUILD.bazel in oppialogger inside domain module #3739

Merged
merged 15 commits into from
Sep 27, 2021

Conversation

deepanshu731
Copy link
Contributor

@deepanshu731 deepanshu731 commented Aug 26, 2021

Fixed #3324
Created a BUILD.bazel file in oppialogger package inside domain.

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@deepanshu731 deepanshu731 changed the title Fix:3324 Created BUILD.bazel in oppialogger inside domain module Fix #3324: Created BUILD.bazel in oppialogger inside domain module Aug 26, 2021
@BenHenning
Copy link
Sponsor Member

Hi @deepanshu731. My apologies for the delay--I'll need to take a look at this tomorrow.

@BenHenning
Copy link
Sponsor Member

Hi--sorry again about the delay. I still plan to look at this later in the week; I've just had some project emergencies to deal with in the meantime. Thanks for your patience.

@deepanshu731
Copy link
Contributor Author

Hi--sorry again about the delay. I still plan to look at this later in the week; I've just had some project emergencies to deal with in the meantime. Thanks for your patience.

Its okay @BenHenning

@oppiabot
Copy link

oppiabot bot commented Sep 10, 2021

Hi @deepanshu731, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 3 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Sep 10, 2021
@deepanshu731 deepanshu731 removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Sep 10, 2021
@oppiabot
Copy link

oppiabot bot commented Sep 17, 2021

Hi @deepanshu731, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 3 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Sep 17, 2021
@deepanshu731 deepanshu731 removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Sep 19, 2021
Copy link
Sponsor Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @deepanshu731! This looks really solid! Just had a few comments.

Sorry for the extended delay--I plan to prioritize this PR moving forward.

domain/BUILD.bazel Outdated Show resolved Hide resolved
app/BUILD.bazel Outdated Show resolved Hide resolved
@deepanshu731
Copy link
Contributor Author

@BenHenning these tests are failing after updating from develop (Did to resolve merge conflict) maybe some realted to databinding are failing where i didnt change anything , Can you help me out with this ?

Copy link
Sponsor Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @deepanshu731. Had just a few more comments, but this PR is looking good to me overall.

@BenHenning these tests are failing after updating from develop (Did to resolve merge conflict) maybe some realted to databinding are failing where i didnt change anything , Can you help me out with this ?

This is a CI flake (see #3759). Restarting should fix it, but given that I requested a couple more changes you could probably just push a new commit with those fixes & CI should pass on the re-run.

@BenHenning BenHenning removed their assignment Sep 26, 2021
deepanshu731 and others added 2 commits September 26, 2021 10:25
…ytics/BUILD.bazel

Co-authored-by: Ben Henning <henning.benmax@gmail.com>
…ptions/BUILD.bazel

Co-authored-by: Ben Henning <henning.benmax@gmail.com>
@deepanshu731
Copy link
Contributor Author

Thanks @deepanshu731. Had just a few more comments, but this PR is looking good to me overall.

@BenHenning these tests are failing after updating from develop (Did to resolve merge conflict) maybe some realted to databinding are failing where i didnt change anything , Can you help me out with this ?

This is a CI flake (see #3759). Restarting should fix it, but given that I requested a couple more changes you could probably just push a new commit with those fixes & CI should pass on the re-run.

Thanks @BenHenning PTAL.

Copy link
Sponsor Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @deepanshu731. PR LGTM! Thanks so much for your patience with the slow reviews.

@BenHenning BenHenning merged commit 15a7772 into oppia:develop Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a BUILD.bazel file for domain/oppialogger
2 participants