Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin Bazel version to 4.0.0 #3758

Merged
merged 2 commits into from
Sep 1, 2021
Merged

Pin Bazel version to 4.0.0 #3758

merged 2 commits into from
Sep 1, 2021

Conversation

BenHenning
Copy link
Sponsor Member

@BenHenning BenHenning commented Sep 1, 2021

Explanation

Pins the Bazel version in the repository to 4.0.0. This has the effect of producing an error like below if the wrong version is used (4.1.0 was pinned used to demonstrate the error):

ERROR: The project you're trying to build requires Bazel 4.1.0 (specified in /home/ben/opensource4/oppia-android/.bazelversion), but it wasn't found in /usr/bin.

You can install the required Bazel version via apt:
  sudo apt update && sudo apt install bazel-4.1.0

If this doesn't work, check Bazel's installation instructions for help:
  https://docs.bazel.build/versions/master/install-ubuntu.html

This is meant to help quickly troubleshoot errors caused by incorrect Bazel environments.

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

N/A

Add codeowners for new .bazelversion file.
@BenHenning BenHenning marked this pull request as ready for review September 1, 2021 19:17
@BenHenning BenHenning requested a review from a team as a code owner September 1, 2021 19:17
@BenHenning
Copy link
Sponsor Member Author

@seanlip PTAL for codeowners change.

@FareesHussain PTAL for the pinning bit since you made a similar change for Android SDK recently.

@BenHenning BenHenning changed the title Pin bazel version Pin Bazel version to 4.0.0 Sep 1, 2021
Copy link
Member

@seanlip seanlip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for codeowners.

Copy link
Contributor

@FareesHussain FareesHussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks

@FareesHussain FareesHussain removed their assignment Sep 1, 2021
@oppiabot oppiabot bot unassigned seanlip Sep 1, 2021
@oppiabot
Copy link

oppiabot bot commented Sep 1, 2021

Unassigning @seanlip since they have already approved the PR.

@oppiabot oppiabot bot added the PR: LGTM label Sep 1, 2021
@oppiabot
Copy link

oppiabot bot commented Sep 1, 2021

Hi @BenHenning, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to merge this PR once the CI checks pass and you're happy with it. Thanks!

@oppiabot
Copy link

oppiabot bot commented Sep 1, 2021

Hi @BenHenning, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to merge this PR once the CI checks pass and you're happy with it. Thanks!

@BenHenning
Copy link
Sponsor Member Author

Thanks!

@BenHenning BenHenning merged commit 8bc6e66 into develop Sep 1, 2021
@BenHenning BenHenning deleted the pin-bazel-version branch September 1, 2021 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants