Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix part of #3775: RTL Exempted file fixes #3776

Merged
merged 6 commits into from
Sep 16, 2021
Merged

Fix part of #3775: RTL Exempted file fixes #3776

merged 6 commits into from
Sep 16, 2021

Conversation

viktoriias
Copy link
Contributor

@viktoriias viktoriias commented Sep 10, 2021

Explanation

Fixes part of #3775: RTL Exempted file fixes.

  • Change app:barrierDirection="right" to app:barrierDirection="end" in topic_practice_subtopic.xml files.
  • Remove fixed/non-existing files from the exempt list.

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

@viktoriias viktoriias marked this pull request as draft September 10, 2021 18:38
@viktoriias viktoriias changed the title 3775 Fix part of #3775: RTL Exempted file fixes Sep 10, 2021
@viktoriias
Copy link
Contributor Author

|

@viktoriias
Copy link
Contributor Author

|

@viktoriias viktoriias marked this pull request as ready for review September 10, 2021 19:57
@viktoriias
Copy link
Contributor Author

@rt4914 @veena14cs Please review.

Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Before vs After Screenshot for reference

@rt4914 rt4914 assigned BenHenning and unassigned rt4914 Sep 14, 2021
Copy link
Sponsor Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @viktoriias! This looks great--glad to see the cleanup!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants