Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge xml #3845

Merged
merged 5 commits into from
Sep 30, 2021
Merged

Merge xml #3845

merged 5 commits into from
Sep 30, 2021

Conversation

aadityaguptaa
Copy link
Contributor

Fixes #3580

merges the 4 xmls of topic_lessons_fragment into single xml file

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes

--Before ss of the Portrait mode mobile
ss portrait before

--After ss of the Portrait mode mobile
ss portrait after

--Before ss of the landscape mode mobile
ss landscape before

--After ss of the landscape mode mobile
ss portrait after

@rt4914 rt4914 self-assigned this Sep 28, 2021
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@rt4914 rt4914 merged commit 1173afc into oppia:develop Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge topic_lessons_fragment.xml into single xml file
2 participants