Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for making the file RTL compatible #3847

Merged
merged 3 commits into from
Sep 29, 2021

Conversation

bkaur-bkj
Copy link
Contributor

Explanation

Fixes #3807 By removing the right constraints from the xml file
removed the file name from exempted files list

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passin
    WhatsApp Image 2021-09-27 at 12 21 58 PM (1)

WhatsApp Image 2021-09-27 at 12 21 58 PM

Added a screenshot for the normal app view and view after selecting force RTL layout. Both were similar to as of before the changes were made.

Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bkaur-bkj Thanks. There is one git file visible in Files Changed section. Just get rid of it and then the tests should pass. The Files Changed section should contain only those files to which you have made changes.

@bkaur-bkj
Copy link
Contributor Author

@bkaur-bkj Thanks. There is one git file visible in Files Changed section. Just get rid of it and then the tests should pass. The Files Changed section should contain only those files to which you have made changes.

Yes sir made the changes

@bkaur-bkj
Copy link
Contributor Author

bkaur-bkj commented Sep 27, 2021

@oppiabot oppiabot bot assigned rt4914 and unassigned bkaur-bkj Sep 27, 2021
@oppiabot
Copy link

oppiabot bot commented Sep 27, 2021

Unassigning @bkaur-bkj since a re-review was requested. @bkaur-bkj, please make sure you have addressed all review comments. Thanks!

Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@rt4914 rt4914 assigned BenHenning and unassigned rt4914 Sep 28, 2021
Copy link
Sponsor Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @bkaur-bkj!

@BenHenning BenHenning merged commit e631ffe into oppia:develop Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RTL Exempted file] Fix add_profile_activity.xml
3 participants