-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes for making the file RTL compatible #3847
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bkaur-bkj Thanks. There is one git
file visible in Files Changed
section. Just get rid of it and then the tests should pass. The Files Changed
section should contain only those files to which you have made changes.
Yes sir made the changes |
@rt4914 sir PTAL on this error log https://github.com/oppia/oppia-android/pull/3847/checks?check_run_id=3717818072#step:15:1548 |
Unassigning @bkaur-bkj since a re-review was requested. @bkaur-bkj, please make sure you have addressed all review comments. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @bkaur-bkj!
Explanation
Fixes #3807 By removing the right constraints from the xml file
removed the file name from exempted files list
Essential Checklist
For UI-specific PRs only
If your PR includes UI-related changes, then:
Added a screenshot for the normal app view and view after selecting force RTL layout. Both were similar to as of before the changes were made.