Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3829: Localisation updates from https://translatewiki.net. #3849

Merged
merged 3 commits into from
Sep 28, 2021

Conversation

translatewiki
Copy link
Member

@translatewiki translatewiki commented Sep 27, 2021

Fix #3829

Translation updates

@BenHenning
Copy link
Sponsor Member

#3795 will need to be merged first since it institutes new CI checks that this will fail (namely around using %d type specifiers), and I'd prefer to not make too many major changes to that PR since it'll slow things down.

@BenHenning BenHenning changed the title Localisation updates from https://translatewiki.net. Fix #3829: Localisation updates from https://translatewiki.net. Sep 27, 2021
@BenHenning BenHenning added this to the Alpha MR3 milestone Sep 27, 2021
@BenHenning
Copy link
Sponsor Member

CI is failing as expected. Gonna push a commit to fix the type specifiers, then I'll merge it once CI indicates everything's good.

Switch digit type specifiers over to strings as now expected.
Copy link
Sponsor Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM from what I can tell. Relying on CI for full correctness.

@oppiabot
Copy link

oppiabot bot commented Sep 28, 2021

Unassigning @BenHenning since they have already approved the PR.

@oppiabot oppiabot bot added the PR: LGTM label Sep 28, 2021
@oppiabot
Copy link

oppiabot bot commented Sep 28, 2021

Hi @translatewiki, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to merge this PR once the CI checks pass and you're happy with it. Thanks!

@BenHenning
Copy link
Sponsor Member

CI is green. Merging.

@BenHenning BenHenning merged commit c1d22df into develop Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plurals aren't translated correctly for Arabic
2 participants