Fix #371, #373, #374: Update exploration json to latest versions #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
& image references are correct. Also, add some missing properties that are nice to have in ratios explorations.
…ations are" This reverts commit b672f7e.
seanlip
approved these changes
Nov 17, 2019
|
Thanks! |
BenHenning
added a commit
that referenced
this pull request
Nov 17, 2019
…tion [Blocked: #390] (#391) * Update fractions lessons to be most up-to-date to ensure that all audio & image references are correct. Also, add some missing properties that are nice to have in ratios explorations. * Remove temporary legacy feedback parsing code now that explorations are up-to-date. * Revert "Remove temporary legacy feedback parsing code now that explorations are" This reverts commit b672f7e. * Fix tests. * Skip first 4 states in the 'meaning of equal parts' exploration. * Fix broken test. * Skip first 4 states in the 'meaning of equal parts' exploration. * Fix broken test. * Readd EOF newlines lost after rebase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #371.
Fix #373.
Fix #374.
All three of these issues were caused by the audio & image references being wrong in the fractions lessons, likely due to them being old. This PR updates fractions lessons so that each work correctly. It also adds some nice-to-have missing fields to all lessons, such as version and ID.
This also updates StateRetriever to remove legacy parsing code now that the fractions explorations are using the latest schema version.StateRetriever can't be updated yet since some of the questions structures appear to rely on this legacy parsing.
Verified all domain tests are passing.