-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #3189: Create build bazel for each subdirectories of util parser new branch #3915
Fix #3189: Create build bazel for each subdirectories of util parser new branch #3915
Conversation
Thanks @yash10019coder. Apologies, but I'll need to take a look at this on Monday. In the meantime, I suggest taking a look at the CI failures & fixing them. |
@FareesHussain made a new commit and getting this error please help |
@yash10019coder You need to make changes as mentioned in the error message |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @yash10019coder! Gave it a first pass.
Another point: no dependencies elsewhere in the app are being updated to use these new ones (which doesn't seem right since, by adding the BUILD.bazel files, these will automatically be excluded from //utility:utility). Please update other libraries & test deps in the app to point to these new libraries, as needed.
utility/src/main/java/org/oppia/android/util/parser/BUILD.bazel
Outdated
Show resolved
Hide resolved
utility/src/main/java/org/oppia/android/util/parser/BUILD.bazel
Outdated
Show resolved
Hide resolved
utility/src/main/java/org/oppia/android/util/parser/html/BUILD.bazel
Outdated
Show resolved
Hide resolved
utility/src/main/java/org/oppia/android/util/parser/html/BUILD.bazel
Outdated
Show resolved
Hide resolved
utility/src/main/java/org/oppia/android/util/parser/image/BUILD.bazel
Outdated
Show resolved
Hide resolved
utility/src/main/java/org/oppia/android/util/parser/image/BUILD.bazel
Outdated
Show resolved
Hide resolved
utility/src/main/java/org/oppia/android/util/parser/image/BUILD.bazel
Outdated
Show resolved
Hide resolved
utility/src/main/java/org/oppia/android/util/parser/svg/BUILD.bazel
Outdated
Show resolved
Hide resolved
…d its subdirectories.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adresed all the comments
utility/src/main/java/org/oppia/android/util/parser/image/BUILD.bazel
Outdated
Show resolved
Hide resolved
utility/src/main/java/org/oppia/android/util/parser/BUILD.bazel
Outdated
Show resolved
Hide resolved
utility/src/main/java/org/oppia/android/util/parser/html/BUILD.bazel
Outdated
Show resolved
Hide resolved
utility/src/main/java/org/oppia/android/util/parser/html/BUILD.bazel
Outdated
Show resolved
Hide resolved
utility/src/main/java/org/oppia/android/util/parser/image/BUILD.bazel
Outdated
Show resolved
Hide resolved
utility/src/main/java/org/oppia/android/util/parser/image/BUILD.bazel
Outdated
Show resolved
Hide resolved
utility/src/main/java/org/oppia/android/util/parser/svg/BUILD.bazel
Outdated
Show resolved
Hide resolved
utility/src/main/java/org/oppia/android/util/parser/image/BUILD.bazel
Outdated
Show resolved
Hide resolved
Hi @BenHenning I have done almost all comments only two are left ig glide one and commented code one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @BenHenning I have done almost all comments only two are left ig glide one and commented code one I am having a build error therefore im unable to resolve the glide comment now and for the commented code i have merged four targets into one target as they were having a cycle in dependency graph please help with this error thanks
Can you create a debugging document (per https://github.com/oppia/oppia/wiki/Debugging-Docs) that outlines the different issues that you ran into, what led to those issues, and what you've tried? It's hard for me to provide feedback given the current information; a debugging doc would really help contextualize the problems you're hitting better so that I can give better feedback.
utility/src/main/java/org/oppia/android/util/parser/html/BUILD.bazel
Outdated
Show resolved
Hide resolved
utility/src/main/java/org/oppia/android/util/parser/image/BUILD.bazel
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BenHenning I have adressed both the comments and also created the debugging doc thanks
Sorry, will need to review this tomorrow. Thanks @yash10019coder. I'll follow up on the doc tomorrow (my time). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @BenHenning mentioned all the comments and also added some comments in the code justifying the visibility of the targets PTAL.
Thanks
utility/src/main/java/org/oppia/android/util/parser/svg/BUILD.bazel
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @yash10019coder! Just had a few comments left, otherwise the PR LGTM!
utility/src/main/java/org/oppia/android/util/parser/image/BUILD.bazel
Outdated
Show resolved
Hide resolved
utility/src/main/java/org/oppia/android/util/parser/html/BUILD.bazel
Outdated
Show resolved
Hide resolved
utility/src/main/java/org/oppia/android/util/parser/html/BUILD.bazel
Outdated
Show resolved
Hide resolved
…build-bazel-for-each-subdirectories-of-util-parser-new-branch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @BenHenning mentioned all the comments and also resolved all the comments where you have mentioned "sounds good" PTAL thanks.
utility/src/main/java/org/oppia/android/util/parser/image/BUILD.bazel
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @yash10019coder. Just one comment left to resolve, I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @BenHenning made the requested changes PTAL thanks.
done |
Hi. As of today, some main reviewers have taken time off for the next few weeks, so it may take a little while before we can look at this PR. We appreciate your patience while some of our team members recharge. We'll be fully returning on 4 January 2021. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @yash10019coder! LGTM. This was a gnarly PR, so thanks for your help.
Hi @BenHenning thanks a lot for your reply merry christmas. |
Unassigning @BenHenning since they have already approved the PR. |
Merging since all CI tests are passing. |
Fixes #3189
Explanation
Created the BUILD bazel for the subdirectories of the util/parser I have also separated ImageTransformation and ImageLoader as they were giving cycle error with this PR we'll move towards the goal of Gradle to Bazel migration
Essential Checklist
For UI-specific PRs only
If your PR includes UI-related changes, then: