Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3827: [Portuguese] Translated text overlap #3925

Merged
merged 3 commits into from
Nov 3, 2021
Merged

Fixes #3827: [Portuguese] Translated text overlap #3925

merged 3 commits into from
Nov 3, 2021

Conversation

coder2699
Copy link
Contributor

Explanation

Fixes #3827 : [Portuguese] Translated text overlap

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

Screenshot:-

@coder2699
Copy link
Contributor Author

@srushtirk PTAL

Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@rt4914
Copy link
Contributor

rt4914 commented Oct 18, 2021

@coder2699 Just merge with latest develop after which we can merge this.

@rt4914 rt4914 assigned coder2699 and unassigned srushtirk Oct 18, 2021
@oppiabot
Copy link

oppiabot bot commented Oct 18, 2021

Assigning @srushtirk for code owner reviews. Thanks!

@oppiabot
Copy link

oppiabot bot commented Oct 18, 2021

Unassigning @srushtirk since they have already approved the PR.

@oppiabot oppiabot bot added the PR: LGTM label Oct 18, 2021
@oppiabot
Copy link

oppiabot bot commented Oct 30, 2021

Hi @coder2699, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Oct 30, 2021
@coder2699 coder2699 removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Oct 31, 2021
@coder2699
Copy link
Contributor Author

@rt4914 @srushtirk two tests regarding roboelectric-bazel are failing, can you help me on how to fix them

@BenHenning
Copy link
Sponsor Member

@rt4914 @srushtirk two tests regarding roboelectric-bazel are failing, can you help me on how to fix them

@coder2699 I can help with that.

I think you're hitting an unusual flake in StateFragmentLocalTest that's unrelated to your PR. We recently added a retry mechanism in #3969 that might at least work around this issue. Can you try merging with the latest develop & then see if CI is passing?

@coder2699
Copy link
Contributor Author

@rt4914 @srushtirk two tests regarding roboelectric-bazel are failing, can you help me on how to fix them

@coder2699 I can help with that.

I think you're hitting an unusual flake in StateFragmentLocalTest that's unrelated to your PR. We recently added a retry mechanism in #3969 that might at least work around this issue. Can you try merging with the latest develop & then see if CI is passing?

@BenHenning , thanks I will try it out

@coder2699
Copy link
Contributor Author

@BenHenning it worked, thanks. @rt4914, PTAL

@oppiabot oppiabot bot assigned BenHenning and rt4914 and unassigned coder2699 Nov 2, 2021
@oppiabot
Copy link

oppiabot bot commented Nov 2, 2021

Unassigning @coder2699 since a re-review was requested. @coder2699, please make sure you have addressed all review comments. Thanks!

@BenHenning
Copy link
Sponsor Member

Thanks @coder2699. Given this is approved and there are no open comment threads, going ahead & merging this.

@BenHenning BenHenning merged commit 65d8c1e into oppia:develop Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Portuguese] Translated text overlap
4 participants