Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3904: [A11Y] Optimised Add Profile Flow #3929

Merged
merged 2 commits into from
Oct 22, 2021
Merged

Conversation

rt4914
Copy link
Contributor

@rt4914 rt4914 commented Oct 14, 2021

Explanation

Fix #3904: [A11Y] Optimised Add Profile Flow

Earlier after typing pin inside Confirm Pin when user clicks/selects the Done action button inside keyboard the profile was getting created without giving a chance to select/deselect the Allow Downloads option.

To fix this on Done action I have removed the createProfile function call.

Output

Now the A11Y user can navigate to all views easily.

device-2021-10-14-201601.mp4

Espresso Test Output

Screenshot 2021-10-14 at 10 08 36 PM

Without the solution (new test fails)

Screenshot 2021-10-21 at 1 30 17 PM

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

@BenHenning
Copy link
Sponsor Member

Hi @rt4914. Apologies, will need to look at this tomorrow.

@BenHenning
Copy link
Sponsor Member

Sorry, I'll need to review this on Monday.

Copy link
Sponsor Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rt4914. This seems like a good fix for non-a11y users, too. Just had one comment, other PR LGTM. PTAL.

@BenHenning BenHenning assigned rt4914 and unassigned BenHenning Oct 19, 2021
@rt4914 rt4914 assigned BenHenning and unassigned rt4914 Oct 21, 2021
Copy link
Sponsor Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rt4914. LGTM!

@BenHenning BenHenning merged commit b0c98e7 into develop Oct 22, 2021
@BenHenning BenHenning deleted the a11y-add-profile-fix branch October 22, 2021 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[A11Y] Unable to reach Switch during AddProfile
2 participants