Fix #3905: A11y flow fix for ProfileProgressHeader

[rt4914]

Explanation

Fix #3905: A11y flow fix for ProfileProgressHeader

Earlier the flow for profile progress was really bad. This PR tries to improve that experience.

Issue

incorrect_flow.mp4

New Flow

device-2021-10-14-233854.mp4

Espresso Tests are passing

Essential Checklist

• The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
• Any changes to scripts/assets files have their rationale included in the PR explanation.
• The PR follows the style guide.
• The PR does not contain any unnecessary code changes from Android Studio (reference).
• The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
• The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

• Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
• For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
• Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
• Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

[BenHenning]

Hi @rt4914. Apologies, will need to look at this tomorrow.

[BenHenning]

Sorry, I'll need to review this on Monday.

[BenHenning]

Thanks @rt4914! This seems sensible--is there any way to add tests for the changes, though? Also, any idea on the test failure; is it related to this PR?

[rt4914]

Thanks @rt4914! This seems sensible--is there any way to add tests for the changes, though? Also, any idea on the test failure; is it related to this PR?

@BenHenning I have tried adding test cases and I am unable to think of any other ways we can test it but at least this strategy makes sure if something changes the test case fails.

All tests are passing now.

[BenHenning]

Thanks @rt4914. I think the new tests are a bit change-detectory, but they're probably the best we can do since there isn't a way to simulate a11y flows in Robolectric so far as I know. This will for sure ensure that we don't regress the actual fix, but won't necessarily prevent other failures occurring in the future. We'll need to rely on manual testing for those.

[BenHenning]

Merging since everything seems addressed now. Thanks @rt4914!