Update version.bzl to have clearer version code instructions #3940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanlip
approved these changes
Oct 16, 2021
seanlip
approved these changes
Oct 16, 2021
version.bzl
Outdated
| @@ -1,5 +1,6 @@ | |||
| """ | |||
| Defines the latest version of the Oppia Android app. | |||
| Defines the latest version of the Oppia Android app. Note that version codes must be ordered such | |||
| that dev < alpha, and kitkat < lollipop+. | |||
There was a problem hiding this comment.
Maybe say something like "This will ensure that the Play Store provides users with the correct version of the app when their device qualifies for more than one choice."
There was a problem hiding this comment.
Nice suggestion, done.
Improve top-level file comment per reviewer suggestion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
It's important to ensure that version codes are correctly ordered to ensure the Play Store provides users with the correct app when their device qualifies for more than one choice.
Essential Checklist
For UI-specific PRs only
N/A