Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #3922: Hi fi tablet create profile rename fragment #3947

Merged
merged 37 commits into from
Dec 10, 2021
Merged

Fix #3922: Hi fi tablet create profile rename fragment #3947

merged 37 commits into from
Dec 10, 2021

Conversation

yash10019coder
Copy link
Contributor

@yash10019coder yash10019coder commented Oct 19, 2021 •
edited

Explanation

Fixes #3922
Created the the fragment and its layout

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).
Old New
Screenshot_20211128_133412 mobile_port
Screenshot_20211128_133415 mobile_land
Screenshot_20211128_133217 tab_port
Screenshot_20211128_133223 tab_land

image
image

@rt4914
Copy link
Contributor

rt4914 commented Oct 19, 2021

@yash10019coder Please follow these steps whenever PR is ready for review: https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section

@BenHenning
Copy link
Sponsor Member

Is this ready for review @yash10019coder?

@yash10019coder
Copy link
Contributor Author

No It isn't ready yet , I will sure do it at the end of the Oct

@BenHenning
Copy link
Sponsor Member

Sounds good, thanks @yash10019coder! In that case, I'm going to convert this to a 'Draft' so that it's clearer that this isn't yet finished. You can convert it back to being a non-Draft once it's ready.

@BenHenning BenHenning marked this pull request as draft October 22, 2021 04:11
@yash10019coder
Copy link
Contributor Author

Hi getting this error @rt4914
image
please help
AAPT: /home/ubuntu/opensource/oppia-android/app/build/intermediates/incremental/mergeDebugResources/stripped.dir/layout-sw600dp-v13/profile_progress_header.xml:19: error: resource dimen/profile_edit_image_layout_margin_start (aka org.oppia.android:dimen/profile_edit_image_layout_margin_start) not found. /home/ubuntu/opensource/oppia-android/app/build/intermediates/incremental/mergeDebugResources/stripped.dir/layout-sw600dp-v13/profile_progress_header.xml:45: error: resource dimen/profile_name_text_view_layout_margin_end (aka org.oppia.android:dimen/profile_name_text_view_layout_margin_end) not found. /home/ubuntu/opensource/oppia-android/app/build/intermediates/incremental/mergeDebugResources/stripped.dir/layout-sw600dp-v13/profile_progress_header.xml:153: error: resource dimen/recently_played_stories_text_view_layout_margin_start (aka org.oppia.android:dimen/recently_played_stories_text_view_layout_margin_start) not found. /home/ubuntu/opensource/oppia-android/app/build/intermediates/incremental/mergeDebugResources/stripped.dir/layout-sw600dp-v13/profile_progress_header.xml:169: error: resource dimen/view_all_text_view_margin_end (aka org.oppia.android:dimen/view_all_text_view_margin_end) not found. error: failed linking file resources.
thanks

@rt4914 rt4914 self-assigned this Oct 26, 2021
@rt4914
Copy link
Contributor

rt4914 commented Oct 26, 2021

@yash10019coder Unassigning as Veena has provided you reference to implement this PR.

@rt4914 rt4914 assigned yash10019coder and unassigned rt4914 Oct 26, 2021
@rt4914 rt4914 assigned rt4914 and unassigned yash10019coder Nov 2, 2021
@yash10019coder
Copy link
Contributor Author

hi @rt4914 here's the video

simplescreenrecorder-2021-11-02_22.37.29.mp4

@BenHenning
Copy link
Sponsor Member

Hi. FYI I've been out the last couple of weeks, so I'm working to catch up on my reviews. I might be delayed a couple of days, but I'll be reviewing this soon. Thanks for your patience!

@rt4914 rt4914 mentioned this pull request Dec 7, 2021
Merged
6 tasks
rt4914
rt4914 suggested changes Dec 7, 2021
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more change, in test cases a lot of multiple lines code can be reduced to single line. I have left 2 comments but check for them throughout the file. Thanks.

app/src/sharedTest/java/org/oppia/android/app/settings/profile/ProfileRenameFragmentTest.kt Outdated Show resolved Hide resolved
app/src/sharedTest/java/org/oppia/android/app/settings/profile/ProfileRenameFragmentTest.kt Outdated Show resolved Hide resolved
@rt4914 rt4914 assigned yash10019coder and unassigned rt4914 Dec 7, 2021
yash10019coder
yash10019coder commented Dec 8, 2021
View reviewed changes
Copy link
Contributor Author

@yash10019coder yash10019coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rt4914 @BenHenning made and commented all the requested changes PTAL

@yash10019coder yash10019coder reopened this Dec 8, 2021
rt4914
rt4914 suggested changes Dec 8, 2021
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yash10019coder PTAL

app/src/sharedTest/java/org/oppia/android/app/settings/profile/ProfileRenameFragmentTest.kt Outdated Show resolved Hide resolved
app/src/sharedTest/java/org/oppia/android/app/settings/profile/ProfileRenameFragmentTest.kt Outdated Show resolved Hide resolved
app/src/sharedTest/java/org/oppia/android/app/settings/profile/ProfileRenameFragmentTest.kt Outdated Show resolved Hide resolved
@rt4914 rt4914 assigned yash10019coder and unassigned rt4914 Dec 8, 2021
@rt4914
Copy link
Contributor

rt4914 commented Dec 8, 2021

@yash10019coder Merge with latest develop too.

BenHenning
BenHenning approved these changes Dec 10, 2021
View reviewed changes
Copy link
Sponsor Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for codeowners (only had 2 files to check).

@BenHenning BenHenning removed their assignment Dec 10, 2021
rt4914
rt4914 approved these changes Dec 10, 2021
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@rt4914 rt4914 merged commit 4a897a1 into oppia:develop Dec 10, 2021
@yash10019coder yash10019coder mentioned this pull request Jun 14, 2022
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rt4914 rt4914 rt4914 approved these changes

@BenHenning BenHenning BenHenning approved these changes

Assignees

@rt4914 rt4914

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Introduce ProfileRenameFragment
3 participants
@yash10019coder @rt4914 @BenHenning