Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3566: Merge profile_rename_activity.xml into single xml file #3950

Merged
merged 8 commits into from
Nov 9, 2021
Merged

Fix #3566: Merge profile_rename_activity.xml into single xml file #3950

merged 8 commits into from
Nov 9, 2021

Conversation

MohitGupta121
Copy link
Member

@MohitGupta121 MohitGupta121 commented Oct 20, 2021

Fix Issue #3566

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).
OLD Screenshots Mobile NEW Screenshots Mobile
Screenshot_20210804_152357 Screenshot_20210804_152357
Screenshot_20210804_152412 Screenshot_20210804_152412
OLD Screenshots TABLET NEW Screenshots TABLET
Screenshot_20210804_152456 Screenshot_20210804_152456
Screenshot_20210804_152510 Screenshot_20210804_152510

@MohitGupta121
Copy link
Member Author

@rt4914 bro please review my pull request for issue #3950 .

@oppiabot
Copy link

oppiabot bot commented Oct 27, 2021

Hi @MohitGupta121, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Oct 27, 2021
@MohitGupta121
Copy link
Member Author

@rt4914 this PR is automatically closed what I can do now, can you please review this PR

@oppiabot oppiabot bot removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Oct 27, 2021
@oppiabot
Copy link

oppiabot bot commented Nov 3, 2021

Hi @MohitGupta121, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added stale Corresponds to items that haven't seen a recent update and may be automatically closed. and removed stale Corresponds to items that haven't seen a recent update and may be automatically closed. labels Nov 3, 2021
@MohitGupta121
Copy link
Member Author

@rt4914 can u please review my this pull request.

Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@rt4914 rt4914 merged commit 65f04b7 into oppia:develop Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants