Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LogStorageModule.kt #3965

Merged
merged 2 commits into from
Oct 25, 2021
Merged

Conversation

BenHenning
Copy link
Sponsor Member

@BenHenning BenHenning commented Oct 22, 2021

Explanation

Fix #3949

This increases the event log to 50k total events (from 5k). This results in a 10x change in total event storage, but for an estimated 3.33MB total space now being needed this seems reasonable long-term. We specifically want this for the upcoming alpha MR4 study to ensure that events can be collected for potentially weeks without internet syncing, but that also matches longer-term goals of the app.

Note that no testing changes occur since this is just a configuration knob, and we don't currently have any module tests. They could be trivially added in the future, but this is simple enough to inspect directly so a test doesn't seem urgently needed for this PR.

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

N/A -- configuration-only change with no UI implications*.

* Technically, this may result in 50k event logs being viewable from the developer menu, but this realistically will never happen. If, in the event it does, the recycler view that's being used for event logs should be suitable to handle the load.

Increase event log cache storage to 50k
Use underscore to make 50k easier to read.
@BenHenning BenHenning added this to the Alpha MR4 milestone Oct 22, 2021
@BenHenning
Copy link
Sponsor Member Author

BenHenning commented Oct 22, 2021

SIGSEGV on StateFragmentLocalTest. Rerunning per #2844.

@BenHenning BenHenning marked this pull request as ready for review October 22, 2021 01:24
@BenHenning
Copy link
Sponsor Member Author

@vinitamurthi PTAL.

@vinitamurthi
Copy link
Contributor

Merging this

@vinitamurthi vinitamurthi merged commit 02013ab into develop Oct 25, 2021
@vinitamurthi vinitamurthi deleted the increase-log-storage-requirements branch October 25, 2021 02:55
@BenHenning
Copy link
Sponsor Member Author

Thanks @vinitamurthi!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase the app config to 50000 events across all profiles
2 participants