-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #3332: Created a BUILD.bazel file in domain/audio #3967
Fix #3332: Created a BUILD.bazel file in domain/audio #3967
Conversation
…the needed targets
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @BenHenning created a PR PTAL
Thanks @yash10019coder. Apologies, will need to look at this tomorrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @yash10019coder. Just had a couple of comments, otherwise the PR looks quite good to me.
Regarding the PR itself, three things:
- Could you please update the title? It's currently cut-off. Titles should generally be concise and specific as to the high-level thing the PR is accomplishing.
- Could you please move the explanation portion in your PR description to be under the 'explanation' section?
- You can (& should) remove the bits under "For UI-specific PRs only" and describe why this PR doesn't need that (e.g. "N/A -- this PR is only changing the Bazel build graph and doesn't affect any user flows"). In general, please make sure to follow the instructions in the PR description to ensure that all the needed pieces are included. This really helps both reviewers and future people who come across the PR after it gets merged.
domain/src/main/java/org/oppia/android/domain/audio/BUILD.bazel
Outdated
Show resolved
Hide resolved
Co-authored-by: Ben Henning <henning.benmax@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BenHenning Please PTAL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @BenHenning added the dependencies and removed the old dependencies from domian/bazel PTAL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @yash10019coder! The PR LGTM.
Two things:
- I updated your PR description since you didn't address point (3) in my earlier comment. Please see how I changed it for a reference on future PRs--copying that approach will help streamline future PRs that you send.
- Please remember to reply to comment threads directly when they're addressed
Thanks a lot, @BenHenning for merging this PR 😄 |
apologies for not replying I forgot I will always reply in the future for all the comments |
Thanks @yash10019coder, I appreciate it. :) |
Explanation
Fixes #3332
Created the bazel file in audio and also added targets to the needed targets.
Essential Checklist
For UI-specific PRs only
N/A -- this PR is only changing the Bazel build graph and doesn't affect any user flows.