Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3978: Removed unused colors from colors.xml #3979

Merged
merged 1 commit into from
Nov 4, 2021

Conversation

ayush0402
Copy link
Contributor

Explanation

Fixes #3978
Removed unused colors from colors.xml.
Followed approach according to https://stackoverflow.com/a/31669368/14822653

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

@rt4914
Copy link
Contributor

rt4914 commented Nov 3, 2021

@ayush0402 Rerunning the test cases as they are failing. If these pass, I can approve it and it should be good to merge. Thanks.

@rt4914
Copy link
Contributor

rt4914 commented Nov 4, 2021

Tried running it again as I am unable to figure why the test is failing.

Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as finally all test passed. Thanks @ayush0402

@rt4914 rt4914 merged commit b26aa8d into oppia:develop Nov 4, 2021
@ayush0402 ayush0402 deleted the removing_unused_colors branch February 10, 2022 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Removing unused colors from colors.xml [Dark Mode Implementation]
2 participants