Fix part of #3602: Add label for Walk Through Activity #3983

priyatanu · 2021-11-07T09:18:48Z

Explanation

Fix part of #3602: Add label for Walk Through Activity

Essential Checklist

The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
Any changes to scripts/assets files have their rationale included in the PR explanation.
The PR follows the style guide.
The PR does not contain any unnecessary code changes from Android Studio (reference).
The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
The PR is assigned to the appropriate reviewers (reference).

BenHenning

Thanks @priyatanu! I left one high-level comment. However, beyond that:

The PR title should be "Fix part of [A11y] Add label for all non-test activities #3602" since this isn't addressing everything covered by that issue
You should add a description in the explanation section of the PR to explain what this PR is doing
The "For UI-specific PRs only" portion of the PR description needs to be filled in since this PR is changing a user behavior

Please update these & at-mention me once they've been addressed.

BenHenning · 2021-11-10T05:59:16Z

app/src/main/AndroidManifest.xml

@@ -215,6 +215,7 @@
      android:theme="@style/OppiaThemeWithoutActionBar" />
    <activity
      android:name=".app.walkthrough.WalkthroughActivity"
+      android:label="@string/walk_through_activity_title"


We also need to make sure that there's a test to verify this. See https://github.com/oppia/oppia-android/pull/3227/files as a reference PR for all the parts needed to add a new accessibility label.

oppiabot · 2021-11-17T06:01:18Z

Hi @priyatanu, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

priyatanu · 2021-11-18T08:59:26Z

Hi @priyatanu, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue. If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

Thank you. I will look into this

BenHenning · 2021-11-20T00:53:28Z

FYI I'm listed as a codeowner for this PR & I'll be unavailable to perform code reviews over the next 2 weeks--thanks for your patience.

rt4914 · 2021-11-24T04:06:02Z

@Arjupta Can you please review this PR first? Thanks.

rt4914 · 2021-11-24T04:06:46Z

@priyatanu Thanks for the PR. Please assign PRs to @Arjupta first has he your mentor that way its easier to review PRs and communicate effectively.

priyatanu · 2021-11-24T18:37:10Z

@priyatanu Thanks for the PR. Please assign PRs to @Arjupta first has he your mentor that way its easier to review PRs and communicate effectively.

Thank you

rt4914

@priyatanu PTAL.
Also please add screenshot in PR description showing that test is is passing on Espresso.

app/src/main/AndroidManifest.xml

app/src/main/res/values/strings.xml

app/src/sharedTest/java/org/oppia/android/app/walkthrough/WalkthroughActivityLabelTest.kt

priyatanu · 2021-12-04T18:47:14Z

…ughActivityTest

priyatanu · 2021-12-04T19:02:12Z

priyatanu · 2021-12-04T19:02:28Z

Arjupta

@priyatanu one static check is failing because we have previously kept the WalkthroughActivity exempted from failing accessiblity issues but as you have resolved them now so it is unnecessary for the file to be exempted further, hence you need to remove the name of WalkthroughActivity from scripts/assets/accessibility_label_exemptions.textproto

rt4914

@priyatanu PTAL thanks.

Also, please mention Fix part of #3602: Add label for Walk Through Activity in your PR description also.

app/src/sharedTest/java/org/oppia/android/app/walkthrough/WalkthroughActivityTest.kt

oppiabot · 2021-12-15T22:09:20Z

Hi @priyatanu, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

BenHenning · 2021-12-17T05:50:35Z

Hi. As of today, some main reviewers have taken time off for the next few weeks, so it may take a little while before we can look at this PR. We appreciate your patience while some of our team members recharge. We'll be fully returning on 4 January 2021.

priyatanu · 2021-12-28T08:04:33Z

Arjupta

LGTM. @rt4914 PTAL

oppiabot · 2022-01-01T11:04:04Z

Assigning @rt4914 for code owner reviews. Thanks!

rt4914

LGTM, thanks.

BenHenning

Thanks @priyatanu! Sorry for the late review--this LGTM!

Add lable for Wal Through Activity

326929d

priyatanu requested a review from BenHenning as a code owner November 7, 2021 09:18

priyatanu changed the title ~~Add label for Wal Through Activity~~ Fix #3602: Add label for Walk Through Activity Nov 7, 2021

priyatanu mentioned this pull request Nov 7, 2021

[A11y] Add label for all non-test activities #3602

Closed

6 tasks

BenHenning assigned priyatanu and BenHenning and unassigned priyatanu Nov 9, 2021

BenHenning requested changes Nov 10, 2021

View reviewed changes

BenHenning assigned priyatanu and unassigned BenHenning Nov 10, 2021

oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Nov 17, 2021

oppiabot bot removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Nov 18, 2021

Add Test WalkthroughActivityLabelTest for adding label to Activity

90b6f59

priyatanu requested a review from rt4914 as a code owner November 21, 2021 19:18

rt4914 assigned Arjupta and unassigned priyatanu Nov 24, 2021

priyatanu changed the title ~~Fix #3602: Add label for Walk Through Activity~~ Fix part of #3602: Add label for Walk Through Activity Nov 24, 2021

rt4914 self-assigned this Nov 24, 2021

rt4914 suggested changes Nov 26, 2021

View reviewed changes

rt4914 assigned priyatanu and unassigned rt4914 and Arjupta Nov 26, 2021

Remove WalkthroughActivityLabelTest and add the test case in Walkthro…

84be80b

…ughActivityTest

Arjupta suggested changes Dec 8, 2021

View reviewed changes

priyatanu added 2 commits December 8, 2021 17:32

Fix failing accessibiltiy failure and clean up acivity scenario

47b3814

Add new Line to proto file

ee830b5

rt4914 suggested changes Dec 8, 2021

View reviewed changes

app/src/sharedTest/java/org/oppia/android/app/walkthrough/WalkthroughActivityTest.kt Outdated Show resolved Hide resolved

oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Dec 15, 2021

oppiabot bot removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Dec 17, 2021

Fix Test Cases for Walk Through label change

85f8aa8

priyatanu requested review from rt4914 and Arjupta December 28, 2021 09:28

Arjupta approved these changes Jan 1, 2022

View reviewed changes

oppiabot bot assigned rt4914 Jan 1, 2022

rt4914 approved these changes Jan 3, 2022

View reviewed changes

rt4914 assigned BenHenning and unassigned rt4914 Jan 3, 2022

priyatanu requested a review from BenHenning January 4, 2022 05:57

BenHenning approved these changes Jan 8, 2022

View reviewed changes

BenHenning merged commit 87a7acc into oppia:develop Jan 8, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix part of #3602: Add label for Walk Through Activity #3983

Fix part of #3602: Add label for Walk Through Activity #3983

priyatanu commented Nov 7, 2021 •

edited

BenHenning left a comment

BenHenning Nov 10, 2021

oppiabot bot commented Nov 17, 2021

priyatanu commented Nov 18, 2021

BenHenning commented Nov 20, 2021

rt4914 commented Nov 24, 2021

rt4914 commented Nov 24, 2021

priyatanu commented Nov 24, 2021

rt4914 left a comment

priyatanu commented Dec 4, 2021

priyatanu commented Dec 4, 2021

priyatanu commented Dec 4, 2021

Arjupta left a comment

rt4914 left a comment

oppiabot bot commented Dec 15, 2021

BenHenning commented Dec 17, 2021

priyatanu commented Dec 28, 2021

Arjupta left a comment

oppiabot bot commented Jan 1, 2022

rt4914 left a comment

BenHenning left a comment

Fix part of #3602: Add label for Walk Through Activity #3983

Fix part of #3602: Add label for Walk Through Activity #3983

Conversation

priyatanu commented Nov 7, 2021 • edited

Explanation

Essential Checklist

BenHenning left a comment

Choose a reason for hiding this comment

BenHenning Nov 10, 2021

Choose a reason for hiding this comment

oppiabot bot commented Nov 17, 2021

priyatanu commented Nov 18, 2021

BenHenning commented Nov 20, 2021

rt4914 commented Nov 24, 2021

rt4914 commented Nov 24, 2021

priyatanu commented Nov 24, 2021

rt4914 left a comment

Choose a reason for hiding this comment

priyatanu commented Dec 4, 2021

priyatanu commented Dec 4, 2021

priyatanu commented Dec 4, 2021

Arjupta left a comment

Choose a reason for hiding this comment

rt4914 left a comment

Choose a reason for hiding this comment

oppiabot bot commented Dec 15, 2021

BenHenning commented Dec 17, 2021

priyatanu commented Dec 28, 2021

Arjupta left a comment

Choose a reason for hiding this comment

oppiabot bot commented Jan 1, 2022

rt4914 left a comment

Choose a reason for hiding this comment

BenHenning left a comment

Choose a reason for hiding this comment

priyatanu commented Nov 7, 2021 •

edited