Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3971: [RTL] Add style for all the TextViews. #3989

Merged
merged 114 commits into from
Nov 19, 2021

Conversation

veena14cs
Copy link
Contributor

@veena14cs veena14cs commented Nov 8, 2021

Explanation

This PR fixes #3971 . This PR ensures that all the Textviews have style attribute set, to generally manage the text alignment for RTL/LTR where the texts are aligned to right or left and the texts that are center-aligned.

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

@veena14cs
Copy link
Contributor Author

Sounds good. Lets keep it as it is for now. Thanks.

Thanks @rt4914 .

Copy link
Sponsor Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @veena14cs. Took a pass on the latest changes--PTAL.

@BenHenning BenHenning removed their assignment Nov 17, 2021
Copy link
Sponsor Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @veena14cs. Just a few comments left. Some of them might be correct as-is per your earlier comments, but I just wanted to double check.

app/src/main/res/values/styles.xml Outdated Show resolved Hide resolved
app/src/main/res/layout/profile_chooser_profile_view.xml Outdated Show resolved Hide resolved
@BenHenning BenHenning assigned veena14cs and unassigned BenHenning Nov 18, 2021
@veena14cs
Copy link
Contributor Author

Thanks @veena14cs. Just a few comments left. Some of them might be correct as-is per your earlier comments, but I just wanted to double check.

@BenHenning I have made changes and addressed your comments PTAL.

@oppiabot oppiabot bot assigned BenHenning and unassigned veena14cs Nov 18, 2021
@oppiabot
Copy link

oppiabot bot commented Nov 18, 2021

Unassigning @veena14cs since a re-review was requested. @veena14cs, please make sure you have addressed all review comments. Thanks!

@rt4914
Copy link
Contributor

rt4914 commented Nov 18, 2021

@BenHenning and @veena14cs I have answered/resolved to all the comment threads that were started by me. Thanks.

Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@rt4914 rt4914 removed their assignment Nov 18, 2021
Copy link
Sponsor Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @veena14cs! I have nothing else to add. I think this is a really nice change toward centrally managing RTL properties, and sets us up for more cleanly organizing centralized styles & enforcing their presence in future work.

@BenHenning
Copy link
Sponsor Member

@BenHenning and @veena14cs I have answered/resolved to all the comment threads that were started by me. Thanks.

Thanks @rt4914!

@BenHenning
Copy link
Sponsor Member

BenHenning commented Nov 19, 2021

Merging since there are no more open conversation threads & everything is approved.

@BenHenning BenHenning merged commit 42878e9 into oppia:develop Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure all TextViews have style attribute set.
3 participants