Fix #386: Add support for local caching of audio & image assets #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change ensures that completed progress is consistent and correct everywhere for fractions and ratios topics. It also ensures that there are thumbnails defined for chapters, and that all thumbnails are consistent regardless of which screen topics, stories, or chapters are viewed from. It updates the reported lesson count to be correct.
caching for audio files.
BenHenning
changed the base branch from
develop
to
calculate-realistic-download-size
BenHenning
changed the title
|
This is blocked on #393. |
vinitamurthi
approved these changes
Nov 19, 2019
domain/src/main/java/org/oppia/domain/exploration/ExplorationRetriever.kt
Show resolved
Hide resolved
jamesxu0
approved these changes
Nov 19, 2019
Conflicts: domain/src/main/java/org/oppia/domain/topic/TopicController.kt
…realistic-download-size
Conflicts: domain/src/main/java/org/oppia/domain/topic/TopicController.kt
BenHenning
changed the title
…repo Conflicts: utility/src/main/java/org/oppia/util/parser/UrlImageParser.kt
Conflicts: domain/src/main/java/org/oppia/domain/topic/TopicController.kt
BenHenning
changed the base branch from
calculate-realistic-download-size
to
develop
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #386.
This PR introduces an AssetRepository that supports caching both JSON and and binary assets (for images and audio files). The repository caches JSON files in memory for faster retrieval, and caches binary files in the app's cache directory.
This PR also updates TopicListController to prime the repository with audio and image files from the 'meaning of equal parts' lesson. This will download all binary assets corresponding to that exploration upon opening the app. This takes a few minutes depending on the device's connection strength and consumes about ~80mb of cache space.
By default, the binary asset caching is disabled using a Dagger flag.
This PR does not introduce any tests because this local caching behavior is temporary until #169 is completed.