Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3901 : [A11Y] Terminal state question player recyclerview fix #4004

Merged
merged 6 commits into from
Dec 10, 2021

Conversation

bkaur-bkj
Copy link
Contributor

@bkaur-bkj bkaur-bkj commented Nov 21, 2021

Explanation

Fixes #3901 ( its a remake of PR #3928 )

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

Espresso test results

test2

test1

A11Y output

WhatsApp.Video.2021-11-23.at.1.26.40.AM.mp4

Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect. Just one comment, pleas take a look at original PR and similar to that add screenshot of passing tests and also video of A11Y output.

@rt4914 rt4914 assigned bkaur-bkj and unassigned rt4914 Nov 22, 2021
@bkaur-bkj
Copy link
Contributor Author

Looks perfect. Just one comment, pleas take a look at original PR and similar to that add screenshot of passing tests and also video of A11Y output.

done sir

@bkaur-bkj bkaur-bkj assigned rt4914 and unassigned bkaur-bkj Nov 22, 2021
@rt4914
Copy link
Contributor

rt4914 commented Nov 22, 2021

@bkaur-bkj For now, just add screenshot of two test cases that you have written. I will look why other tests are failing. Mostly they are flaky.

Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

Will wait for Ben's review after 6th December.

@rt4914 rt4914 assigned bkaur-bkj and unassigned rt4914 Nov 22, 2021
@bkaur-bkj
Copy link
Contributor Author

@bkaur-bkj For now, just add screenshot of two test cases that you have written. I will look why other tests are failing. Mostly they are flaky.

done

@bkaur-bkj bkaur-bkj removed their assignment Nov 23, 2021
@oppiabot
Copy link

oppiabot bot commented Nov 30, 2021

Hi @bkaur-bkj, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Nov 30, 2021
@BenHenning
Copy link
Sponsor Member

Hi. FYI I've been out the last couple of weeks, so I'm working to catch up on my reviews. I might be delayed a couple of days, but I'll be reviewing this soon. Thanks for your patience!

@oppiabot oppiabot bot removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Dec 7, 2021
Copy link
Sponsor Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks solid, thanks @bkaur-bkj! And, thanks @rt4914 for the first implementation that this is based on!

@BenHenning BenHenning merged commit ec69efc into oppia:develop Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[A11Y] Remove blank space from QuestionPlayer
3 participants