Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add holiday messaging for PRs in CI #4065

Merged
merged 2 commits into from
Dec 17, 2021

Conversation

BenHenning
Copy link
Sponsor Member

@BenHenning BenHenning commented Dec 17, 2021

Explanation

A previous attempt to add automatic messaging to PRs didn't work, so manually adding something that will automatically run until the team's multi-person time-off period ends. I'll manually be adding messages to existing PRs since this only operates for new PRs.

Some caveats:

  1. I can't test this until the PR is submitted
  2. It won't work for first-time contributors since their workflows need to be run by a team member with write access, but everyone else should see the message
  3. The workflow will need to be manually disabled once we return (doing a date-based if check is a bit complicated, and I didn't want to have to debug it since this is a temporary thing, anyway)

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

N/A -- CI infrastructure PR.

@BenHenning BenHenning marked this pull request as ready for review December 17, 2021 04:20
@BenHenning
Copy link
Sponsor Member Author

BenHenning commented Dec 17, 2021

Thanks! Enabling auto-merge since the only workflows that could actually fail from this change didn't.

@BenHenning BenHenning enabled auto-merge (squash) December 17, 2021 04:25
@oppiabot oppiabot bot unassigned seanlip Dec 17, 2021
@oppiabot
Copy link

oppiabot bot commented Dec 17, 2021

Unassigning @seanlip since they have already approved the PR.

@oppiabot oppiabot bot added the PR: LGTM label Dec 17, 2021
@oppiabot
Copy link

oppiabot bot commented Dec 17, 2021

Hi @BenHenning, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to merge this PR once the CI checks pass and you're happy with it. Thanks!

@BenHenning BenHenning merged commit c31bc61 into develop Dec 17, 2021
@BenHenning BenHenning deleted the add-holiday-messaging-ci-for-prs branch December 17, 2021 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants