Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3333: Create BUILD.bazel file for domail/profile. #4074

Merged
merged 12 commits into from
Jan 12, 2022

Conversation

rishidyno
Copy link
Contributor

@rishidyno rishidyno commented Dec 30, 2021

Fix #3333

Explanation

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

@github-actions
Copy link

Thanks for submitting this pull request! Some main reviewers
have taken time off for the next few weeks, so it may take a
little while before we can look at this PR. We appreciate your
patience while some of our team members recharge. We'll be fully
returning on 4 January 2021.

@rishidyno
Copy link
Contributor Author

@BenHenning All tests have passes PTAL .

Copy link
Sponsor Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rishidyno! Apologies for the late review. The PR looks good; just had 1 comment nit. PTAL.

@BenHenning BenHenning assigned rishidyno and unassigned BenHenning Jan 8, 2022
Co-authored-by: Ben Henning <henning.benmax@gmail.com>
@rishidyno
Copy link
Contributor Author

@BenHenning PTAL changes were made

@oppiabot oppiabot bot assigned BenHenning and unassigned rishidyno Jan 8, 2022
@oppiabot
Copy link

oppiabot bot commented Jan 8, 2022

Unassigning @rishidyno since a re-review was requested. @rishidyno, please make sure you have addressed all review comments. Thanks!

Copy link
Sponsor Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rishidyno. LGTM!

@BenHenning BenHenning merged commit 4bc4d6a into oppia:develop Jan 12, 2022
@rishidyno rishidyno deleted the bazel-support-for-domain-profile branch January 13, 2022 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a BUILD.bazel in domain/profile
2 participants