Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix part of 405 #408

Merged
merged 1 commit into from
Nov 18, 2019
Merged

Conversation

rt4914
Copy link
Contributor

@rt4914 rt4914 commented Nov 18, 2019

Explanation

This branch name and commit name in this PR is incorrect. It should be 405 instead of 406.

Also, this PR fixes one edge case which we were trying to solve in #405

Steps to reproduce this error which can be checked in #405

  1. Go to any exploration-state which has editext in it.
  2. Try to enter incorrect answers so that the entire content on screen becomes scrollable.
  3. Now, if you enter an incorrect answer, the recyclerview will start from top again which has been fixed in this PR.

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@rt4914
Copy link
Contributor Author

rt4914 commented Nov 18, 2019

@nikitamarysolomanpvt This PR needs to be merged in branch of #405

@rt4914 rt4914 mentioned this pull request Nov 18, 2019
10 tasks
Copy link
Contributor

@nikitamarysolomanpvt nikitamarysolomanpvt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Iam merging this branch with its parent branch as per our discussion.

@nikitamarysolomanpvt nikitamarysolomanpvt merged commit 8289c5e into hi-fi-input-interaction-views Nov 18, 2019
@nikitamarysolomanpvt nikitamarysolomanpvt removed their assignment Nov 26, 2019
@BenHenning BenHenning deleted the fix-406 branch June 10, 2020 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants