-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #3569 Merged promoted_story_list.xml files #4083
Conversation
@rishidyno PTAL |
LGTM @mukulasija. |
Thanks @rishidyno for reviewing this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mukulasija Thanks. PTAL at comments.
Hi @mukulasija, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue. |
@mukulasija always remeber to ask for a review if you have replied with a question to any comments so that the reviewer can answer them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
* merged promoted-story-list files into single xml file * added style attribute to text views as suggested
Fixes #3569 Merged 4 promoted_story_list.xml files into single xml file
Essential Checklist
For UI-specific PRs only
If your PR includes UI-related changes, then: