-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #3554 Merge options_without_drawer_activity.xml #4089
Conversation
There are 3 files with the same name, 2 of them are identical (now merged to a single file) and the third one has a different layout.
PTAL @rt4914 |
Hi @bhaktideshmukh please add proper screenshots of tablet and emulator you can take a look at this PR for reference link and @rt4914 please approve the workflow, thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also try to remove swp600/land and swp600/port and try to run the app and see if anything breaks thanks.
Hi @bhaktideshmukh, it looks like some changes were requested on this pull request by @yash10019coder. PTAL. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, the solution is correct.
@yash10019coder For this PR the description does contain correct screenshots and the reason mentioned is also correct. |
Gentle reminder for merging this PR . |
Unassigning @bhaktideshmukh since a re-review was requested. @bhaktideshmukh, please make sure you have addressed all review comments. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @bhaktideshmukh thanks
Unassigning @yash10019coder since they have already approved the PR. |
Explanation
Fix #3554 : Merge options_without_drawer_activity.xml
There are 3 files with the same name, 2 of them are identical
(now merged to a single file) and the third one has a different
layout.
Essential Checklist
For UI-specific PRs only
If your PR includes UI-related changes, then: