Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3549 Merge option_activity.xml #4090

Merged
merged 1 commit into from
Jan 17, 2022
Merged

Conversation

bhaktideshmukh
Copy link
Contributor

@bhaktideshmukh bhaktideshmukh commented Jan 10, 2022

Explanation

Fix #3549 : Merge option_activity.xml

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

@ayush0402
Copy link
Contributor

ayush0402 commented Jan 16, 2022

@bhaktideshmukh LGTM, Thanks.
Can you please update the PR explanation on all your ongoing PRs to contain fixes #issuenumber for proper tracking of PRs with their issues.
Also, make sure you ask for a review when you think your PR is ready to reviewed.

Edit : I see that you were not yet assigned this issue. Ideally, you should wait till you are assigned before making PRs. Anyway, assigning this issue to you now.

@bhaktideshmukh
Copy link
Contributor Author

@bhaktideshmukh LGTM, Thanks. Can you please update the PR explanation on all your ongoing PRs to contain fixes #issuenumber for proper tracking of PRs with their issues. Also, make sure you ask for a review when you think your PR is ready to reviewed.

Edit : I see that you were not yet assigned this issue. Ideally, you should wait till you are assigned before making PRs. Anyway, assigning this issue to you now.

I updated the pull request with issue number.
What is the process for asking for review?
It was a little fix , so i went ahead. From next time i will wait for the assignment.

Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@rt4914 rt4914 enabled auto-merge (squash) January 17, 2022 19:14
@rt4914 rt4914 assigned bhaktideshmukh and unassigned rt4914 Jan 17, 2022
@rt4914
Copy link
Contributor

rt4914 commented Jan 17, 2022

Thanks @ayush0402 for helping out.

@oppiabot oppiabot bot added the PR: LGTM label Jan 17, 2022
@rt4914 rt4914 merged commit bfaa7a3 into oppia:develop Jan 17, 2022
@ayush0402
Copy link
Contributor

@bhaktideshmukh You can write a comment like PTAL @reviewer_username asking for a review.

bhaktideshmukh added a commit to bhaktideshmukh/oppia-android that referenced this pull request Jan 25, 2022
@bhaktideshmukh bhaktideshmukh deleted the wip1 branch April 6, 2022 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge option_activity.xml into single xml file
3 participants