Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3546 Merge ongoing_topic_list_activity.xml #4091

Merged
merged 1 commit into from
Jan 19, 2022

Conversation

bhaktideshmukh
Copy link
Contributor

@bhaktideshmukh bhaktideshmukh commented Jan 10, 2022

Explanation

Fix #3546 : Merge ongoing_topic_list_activity.xml

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

@bhaktideshmukh
Copy link
Contributor Author

PTAL @rt4914
Thanks.

Copy link
Contributor

@yash10019coder yash10019coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bhaktideshmukh same goes for this PR too and also @rt4914 approve the workflow thanks.

@oppiabot
Copy link

oppiabot bot commented Jan 18, 2022

Hi @bhaktideshmukh, it looks like some changes were requested on this pull request by @yash10019coder. PTAL. Thanks!

Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@rt4914
Copy link
Contributor

rt4914 commented Jan 19, 2022

@yash10019coder Its completely fine not to add screenshot for this specific PR as the efforts required to just compare the two files is far less than actually creating screenshots for the same. Just merge as this is fairly straightforward PR but if you have any concerns feel free to comment.

@rt4914 rt4914 merged commit b9d4b13 into oppia:develop Jan 19, 2022
bhaktideshmukh added a commit to bhaktideshmukh/oppia-android that referenced this pull request Jan 25, 2022
@bhaktideshmukh bhaktideshmukh deleted the wip2 branch April 6, 2022 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge ongoing_topic_list_activity.xml into single xml file
3 participants