Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3563 : Merge profile_progress_fragment.xml into single xml file #4113

Merged

Conversation

bhaktideshmukh
Copy link
Contributor

@bhaktideshmukh bhaktideshmukh commented Jan 19, 2022

Explanation

Fix #3563 : Merge profile_progress_fragment.xml into single xml file

Phone portrait mode

Before After

Phone landscape mode

Before After

Tablet portrait mode

Before After

Tablet landscape mode

Before After

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

@rt4914 rt4914 self-assigned this Jan 19, 2022
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bhaktideshmukh Just took a quick look. The screenshots of before/after do not match in terms of background color. Please check that.

app/src/main/res/values/dimens.xml Outdated Show resolved Hide resolved
app/src/main/res/values/dimens.xml Outdated Show resolved Hide resolved
@rt4914 rt4914 assigned bhaktideshmukh and unassigned rt4914 Jan 19, 2022
@bhaktideshmukh
Copy link
Contributor Author

@rt4914 Hey I've used android:background="@color/transparent" instead of android:background="@color/white" Since in background color white , fragments of after commit weren't matching the fragments of before commit.

@bhaktideshmukh
Copy link
Contributor Author

PTAL @rt4914
Thanks.

@oppiabot oppiabot bot assigned rt4914 and unassigned bhaktideshmukh Jan 20, 2022
@oppiabot
Copy link

oppiabot bot commented Jan 20, 2022

Unassigning @bhaktideshmukh since a re-review was requested. @bhaktideshmukh, please make sure you have addressed all review comments. Thanks!

Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@rt4914 rt4914 enabled auto-merge (squash) January 25, 2022 17:14
@oppiabot oppiabot bot unassigned rt4914 Jan 25, 2022
@oppiabot
Copy link

oppiabot bot commented Jan 25, 2022

Unassigning @rt4914 since they have already approved the PR.

@oppiabot oppiabot bot added the PR: LGTM label Jan 25, 2022
@rt4914 rt4914 merged commit 07bee86 into oppia:develop Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge profile_progress_fragment.xml into single xml file
2 participants