-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #3563 : Merge profile_progress_fragment.xml into single xml file #4113
Fix #3563 : Merge profile_progress_fragment.xml into single xml file #4113
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bhaktideshmukh Just took a quick look. The screenshots of before/after do not match in terms of background color. Please check that.
943a8ee
to
c89a769
Compare
@rt4914 Hey I've used android:background="@color/transparent" instead of android:background="@color/white" Since in background color white , fragments of after commit weren't matching the fragments of before commit. |
PTAL @rt4914 |
Unassigning @bhaktideshmukh since a re-review was requested. @bhaktideshmukh, please make sure you have addressed all review comments. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
Unassigning @rt4914 since they have already approved the PR. |
Explanation
Fix #3563 : Merge profile_progress_fragment.xml into single xml file
Phone portrait mode
Phone landscape mode
Tablet portrait mode
Tablet landscape mode
Essential Checklist
For UI-specific PRs only
If your PR includes UI-related changes, then: