Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3550 : Merge option_app_language.xml into single xml file #4124

Merged
merged 1 commit into from
Jan 25, 2022

Conversation

bhaktideshmukh
Copy link
Contributor

@bhaktideshmukh bhaktideshmukh commented Jan 21, 2022

Explanation

Fix #3550 Merge option_app_language.xml.

Merged layout-land/option_app_language.xml and layout/option_app_language.xml into single xml file. since layout-sw600dp/option_app_language.xml has different layout from the other two so it cannot be merged.

Screenshot from 2022-01-21 14-41-18

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

@bhaktideshmukh
Copy link
Contributor Author

PTAL @rt4914 Thanks.

Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@rt4914 rt4914 enabled auto-merge (squash) January 25, 2022 17:18
@rt4914 rt4914 assigned bhaktideshmukh and unassigned rt4914 Jan 25, 2022
@oppiabot oppiabot bot added the PR: LGTM label Jan 25, 2022
@rt4914 rt4914 merged commit b8db32f into oppia:develop Jan 25, 2022
@bhaktideshmukh bhaktideshmukh deleted the merge_option_app_language branch April 6, 2022 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge option_app_language.xml into single xml file
2 participants