Fix #3565 profile_progress_recently_played_story_card.xml merged into single xml file

[yashbansal130]

Fixes #3565

Essential Checklist

• The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
• Any changes to scripts/assets files have their rationale included in the PR explanation.
• The PR follows the style guide.
• The PR does not contain any unnecessary code changes from Android Studio (reference).
• The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
• The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

• Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes

Screen Before	Screen After

• For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
• Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
• Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

[yash10019coder]

HI @yashbansal130 thanks for creating the PR I suggest you to add screenshots in tabular form you can look at this PR for reference and @rt4914 please approve the workflow

[yashbansal130]

@yash10019coder looks good?

[yash10019coder]

Hi @yashbansal130 you have done almost all the work I have left a comment thanks

[oppiabot]

Hi @yashbansal130, it looks like some changes were requested on this pull request by @yash10019coder. PTAL. Thanks!

[yashbansal130]

@yash10019coder sorry but no change request is visible to me nor any comment.

[yash10019coder]

@yashbansal130 why do we have to add dimensions values for layout-land swp600 and land-swp600 as their layout files are deleted so where are they used

[yashbansal130]

@yashbansal130 why do we have to add dimensions values for layout-land swp600 and land-swp600 as their layout files are deleted so where are they used

they have the same name as other dimen for layout_profile_recently_played_activity so what I know is that it will automatically refer to this dimen depending upon the layout is land/port/sw600dp-land/sw600dp-port

[rt4914]

Will review it once @yash10019coder has approved it.

[yash10019coder]

@yashbansal130 why do we have to add dimensions values for layout-land swp600 and land-swp600 as their layout files are deleted so where are they used

they have the same name as other dimen for layout_profile_recently_played_activity so what I know is that it will automatically refer to this dimen depending upon the layout is land/port/sw600dp-land/sw600dp-port

ok I get that why are we declaring dimes for other configurations

[yash10019coder]

@yashbansal130 please update the screenshots.

[yash10019coder]

and also resolve the merge confilcts.

[yashbansal130]

@yash10019coder
to get new SS, i did fetch and merge and git pull to get the updated code because i was 10 commits behind the develop branch, after doing that my emulator is not showing the whole recyclerview of the recently_played_story_card

[yash10019coder]

This is strange I'll look into this and @rt4914 can you please approve the workflow here thanks

[yash10019coder]

and also yash remember to assign the reviewers if you are asking something from them it lets us know that we have to see this PR

[yashbansal130]

and also yash remember to assign the reviewers if you are asking something from them it lets us know that we have to see this PR

i will keep this in mind surely

[yashbansal130]

This is strange I'll look into this and @rt4914 can you please approve the workflow here thanks

@yash10019coder any updates?

[yash10019coder]

I think that your branch is not up to date with develop you must merge with latest develop thanks

[rt4914]

@yashbansal130 Suggested changes.

@rishidyno @yash10019coder Please have a look at my comments and assign me once they have been finished correctly. Thanks.

[rishidyno]

@yashbansal130 LGTM, thanks.

[oppiabot]

Unassigning @rishidyno since they have already approved the PR.

[yash10019coder]

@yashbansal130 Suggested changes.

@rishidyno @yash10019coder Please have a look at my comments and assign me once they have been finished correctly. Thanks.

@yashbansal130 please always reply on comments so that we can know that you have resolved them

[yash10019coder]

LGTM @yashbansal130 thanks

[oppiabot]

Unassigning @yash10019coder since they have already approved the PR.

[rishidyno]

@rt4914 please aproov the workflows.

[rt4914]

LGTM, thanks

[oppiabot]

Unassigning @rt4914 since they have already approved the PR.