-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #3534: Merge help_without_drawer_activity.xml into single xml file #4144
Fix #3534: Merge help_without_drawer_activity.xml into single xml file #4144
Conversation
Thanks @Akshatkamboj14 LGTM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Akshatkamboj14 arrange the ss in tabular form like this #3523 PR
Hi @Akshatkamboj14, it looks like some changes were requested on this pull request by @yash10019coder. PTAL. Thanks! |
@yash10019coder Done.... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @Akshatkamboj14 thanks
@rt4914 Please approve the workflows. Thanks! |
@Akshatkamboj14 Update the project and static check will pass |
@rt4914 Now I understand why this was happening. Because he is 2 commits behind develop, so his code has |
… Merge_help_without_drawer_activity.xml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
Explanation
Fix #3534: Merge help_without_drawer_activity.xml into single xml fileEssential Checklist
For UI-specific PRs only
If your PR includes UI-related changes, then: