-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #3540 : Merge lessons_chapter_view.xml into single xml file #4146
Fix #3540 : Merge lessons_chapter_view.xml into single xml file #4146
Conversation
@aayushimathur6 PTAL can you please rearrange the image as they are not correct in their current state. |
Also I think the image are incorrect please rectify them. Thanks! |
Before screenshots for landscape modes are not correct. Rest seems to be fine. |
corrected it, please check @ayush0402 @rishidyno !! |
@aayushimathur6 LGTM, Thanks. Just a nit suggestion, try to keep screenshots for comparison to be of same size, you can use size attributes in markdown to fix it. |
@rt4914 Please approve the workflows. Thanks. |
okay @ayush0402 next time I will keep this in my mind |
LGTM Thanks! |
@aayushimathur6 Your PR is 3 commits behind develop. Please update the develop on your fork and also update this branch. You can notice it says "3 commits behind oppia:develop" Once its up-to-date all CI checks should pass. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
… Merge_lessons_chapter_view.xml_into_single_xml_file
Hey @rt4914 please review my changes |
Explanation
Fix #3540 : Merge lessons_chapter_view.xml into single xml fileEssential Checklist
For UI-specific PRs only
If your PR includes UI-related changes, then: